search

cms-sw / cmssw

CMS Offline Software
http://cms-sw.github.io/
Apache License 2.0
1.09k stars 4.32k forks source link

silence or fix HGC validation warnings/errors #21129

Open slava77 opened 7 years ago

slava77 commented 7 years ago

Based on logs from 20034 in the short matrix e.g. in CMSSW_10_0_X_2017-11-01-2300/ https://cmssdt.cern.ch/SDT/jenkins-artifacts/ib-baseline-tests/CMSSW_10_0_X_2017-11-01-2300/slc6_amd64_gcc630/-GenuineIntel/matrix-results/20034.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D17_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D17+RecoFullGlobal_2023D17+HARVESTFullGlobal_2023D17/step3_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D17_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D17+RecoFullGlobal_2023D17+HARVESTFullGlobal_2023D17.log

  1. http://cmslxr.fnal.gov/source/Validation/HGCalValidation/plugins/HGCalRecHitValidation.cc?v=CMSSW_9_4_0_pre3#0143 prints info messages as warnings "Event 1 with 559 total and 559 used recHits"
  2. "no HepMCProduct found" in HGCalSimHitValidation should be configured to use generatorSmeared
  3. "No PHGCalInfo" in HGCGeometryValidation: the input produced by SimG4HGCalValidation in the SIM step is apparently missing. This can be fixed at source or HGCGeometryValidation can be made to skip
slava77 commented 7 years ago

assign upgrade,dqm

cmsbuild commented 7 years ago

New categories assigned: dqm,upgrade

@kmaeshima,@vanbesien,@kpedro88,@vazzolini,@dmitrijus you have been requested to review this Pull request/Issue and eventually sign? Thanks

cmsbuild commented 7 years ago

A new Issue was created by @slava77 Slava Krutelyov.

@davidlange6, @Dr15Jones, @smuzaffar can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

kpedro88 commented 7 years ago

attn: @bsunanda

kpedro88 commented 6 years ago

@bsunanda please address this

bsunanda commented 6 years ago

I am reviewing the HGCalValidation package right now and will take care of these.

slava77 commented 6 years ago

@bsunanda @kpedro88 is this issue still unresolved? Please clarify.

kpedro88 commented 6 years ago

I think #21734 addresses at least some of this, I hope @bsunanda can confirm.

kpedro88 commented 6 years ago

@bsunanda can you confirm if all of these messages have been removed?

kpedro88 commented 5 years ago

@bsunanda ping

kpedro88 commented 5 years ago

@bsunanda ping

fioriNTU commented 5 years ago

@kpedro88 @bsunanda any news on this?

bsunanda commented 5 years ago

Just working on this. Shall submit the PR for master soon

bsunanda commented 5 years ago

Wondering if this needs to be back propagated?

fioriNTU commented 5 years ago

@bsunanda thanks for the prompt action, however I see in the PR conparison that no signficant change in the logs is seen, I was expecting a large change in the logs ... I may be wrong. Anyway, checking the PR it looks clearly to kill printouts.

kpedro88 commented 5 years ago

+upgrade

smuzaffar commented 4 years ago

Do we need any more fixes for this issue?

jfernan2 commented 3 years ago

+1