Closed davidlt closed 6 years ago
A new Issue was created by @davidlt .
@davidlange6, @Dr15Jones, @smuzaffar can you please review it and eventually sign/assign? Thanks.
cms-bot commands are listed here
assign simulation
New categories assigned: simulation
@mdhildreth,@civanch you have been requested to review this Pull request/Issue and eventually sign? Thanks
m_userRunAction
is only set here
https://github.com/cms-sw/cmssw/blob/master/SimG4Core/Application/src/RunManagerMT.cc#L236
which is called from https://github.com/cms-sw/cmssw/blob/master/SimG4Core/Application/src/RunManagerMT.cc#L196
Looking at the logic of the code, it is possible for an exception to happen before reading the initialization of m_userRunAction
which means the destructor would be called and would see an uninitialized value for the member variable.
I beleive the fix is just to set m_userRunAction
to nullptr
in the constructor. Or even better, changed m_userRunAction
to be a std::shared_ptr<>
with a customized delete method.
Could you propose a pull request?
There is one #21363
I can confirm that PR mentioned above resolves the issue.
CMSSW:
CMSSW_10_0_ASAN_X_2017-11-12-1100
SCRAM_ARCH:slc6_amd64_gcc700
Workflow:500199.0
Step:step1
Detailed report:
The problem happens here: https://github.com/cms-sw/cmssw/blob/master/SimG4Core/Application/src/RunManagerMT.cc#L252
m_userRunAction
pointer value is0xbebebebebebebebe
. Now ASan has0xbe
as pattern formalloc_fill_byte
: Value used to fill the newly allocated memory.