Closed dan131riley closed 5 years ago
A new Issue was created by @dan131riley Dan Riley.
@davidlange6, @Dr15Jones, @smuzaffar, @fabiocos can you please review it and eventually sign/assign? Thanks.
cms-bot commands are listed here
assign dqm
New categories assigned: dqm
@kmaeshima,@vanbesien,@jfernan2,@vazzolini,@dmitrijus you have been requested to review this Pull request/Issue and eventually sign? Thanks
The copy of a ParameterSet is inefficient, but should not lead to a crash.
After digging into the implementation, I agree it shouldn't lead to a crash, even with the old ABI COW strings it ought to be safe. Will have to try memcheck on it.
And to clarify, I'd change
edm::ParameterSet psTTStub_Barrel_XY = conf_.getParameter<edm::ParameterSet("TH2TTStub_Position");
to
const edm::ParameterSet& psTTStub_Barrel_XY = conf_.getParameterSet("TH2TTStub_Position");
since there isn't a const&
version of the templated getParameter<>
@dan131riley , @Dr15Jones is there anything to do on our (DQM) side? It seems the problem was not fully understood from the core side.
We did conclude that OuterTrackerMonitorTTStub::beginRun was not responsible for the crash, so I'll close this ticket. The inefficient copying of ParameterSets is still there in OuterTrackerMonitorTTStub::bookHistograms, but that only runs once per run, so I guess it's not worth keeping the ticket open.
https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc6_amd64_gcc630/CMSSW_10_1_X_2018-02-11-1100/pyRelValMatrixLogs/run/20834.11_TTbar_14TeV_Timing+TTbar_14TeV_TuneCUETP8M1_2023D20_GenSimHLBeamSpotFull14_Timing+DigiFull_Timing_2023D20+RecoFullGlobal_Timing_2023D20+HARVESTFullGlobal_Timing_2023D20/step3_TTbar_14TeV_Timing+TTbar_14TeV_TuneCUETP8M1_2023D20_GenSimHLBeamSpotFull14_Timing+DigiFull_Timing_2023D20+RecoFullGlobal_Timing_2023D20+HARVESTFullGlobal_Timing_2023D20.log
There are a bunch of instances of
https://github.com/cms-sw/cmssw/blob/master/DQM/Phase2OuterTracker/plugins/OuterTrackerMonitorTTStub.cc#L177
that I think ought to be
const edm::ParameterSet&