search

cms-sw / cmssw

CMS Offline Software
http://cms-sw.github.io/
Apache License 2.0
1.07k stars 4.29k forks source link

Explore using Modifier to specify if workflow is for validation or not #22494

Open makortel opened 6 years ago

makortel commented 6 years ago

From https://github.com/cms-sw/cmssw/pull/22416#discussion_r172171914: It might be useful to specify whether a workflow is for validation or not with a cms.Modiifer instead of :pdigi_valid specifier to DIGI step. The current solution needs code like following in ConfigBuilder https://github.com/cms-sw/cmssw/blob/997d1ea4289d52d453446b2d378a44e2010f08a2/Configuration/Applications/python/ConfigBuilder.py#L1414-L1415 to customize the digitizers PSet for MixingModule. While this works, doing the same for DataMixingModule/PreMixingModule would be more challenging as the DIGI step is not in the same job as DATAMIX. A modifier could allow rather clean solution. Very likely depends on #22492.

And why to do the same for DataMixingModule/PreMixingModule? To be able to throw exception on missing products instead of noticing them later in private/PPD validation.

cmsbuild commented 6 years ago

A new Issue was created by @makortel Matti Kortelainen.

@davidlange6, @Dr15Jones, @smuzaffar, @fabiocos can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

Dr15Jones commented 6 years ago

@davidlange6 your thoughts?

srimanob commented 3 years ago

Hi @makortel While looking on pdigi_valid, I see this open issue. Do I understand correctly that currently,

Thanks.

makortel commented 3 years ago

In both classical mixing and premixing the validation code is run in RECO step. The difference of pdigi_valid and pdigi Sequences is that using pdigi_valid leads to inclusion of MC truth information (mostly TrackingParticles and various DigiSimLinks) that is necessary for validation but not needed in production (pdigi). Note that the definitions of pdigi_valid and pdigi Sequences themselves are the same https://github.com/cms-sw/cmssw/blob/a2397cc1c67ee908deeb2b458f67df3af17519e9/Configuration/StandardSequences/python/Digi_cff.py#L48-L49 and the difference is made in ConfigBuilder as mentioned in the issue description (that may be a bit unintuitive place to look for).

makortel commented 3 years ago

assign operations

cmsbuild commented 3 years ago

New categories assigned: operations

@fabiocos,@franzoni,@qliphy,@davidlange6,@silviodonato you have been requested to review this Pull request/Issue and eventually sign? Thanks