search

cms-sw / cmssw

CMS Offline Software
http://cms-sw.github.io/
Apache License 2.0
1.07k stars 4.29k forks source link

Allow EDAliases when a job is configured to run MixingModule in playback mode #25923

Open makortel opened 5 years ago

makortel commented 5 years ago

Currently the MixingModule playback mode is set up in cmsDriver.py as https://github.com/cms-sw/cmssw/blob/c52e2819d7a2bca52273e9c36fc99622313eff71/Configuration/Applications/python/ConfigBuilder.py#L1819-L1823

The line deleting all EDAliases is potentially harmful as it essentially prevents using EDAliases e.g. in RAW2DIGI or RECO. The line is there likely because when the MixingModule is configured for playback mode and all digitizers are disabled, the EDAliases pointing to mix will cause EDAlias sanity checks within the framework to throw exceptions (mix module is defined, but the aliased-for products do not exist).

It would be good to find a way to disable these aliases without removing all aliases from a process.

cmsbuild commented 5 years ago

A new Issue was created by @makortel Matti Kortelainen.

@davidlange6, @Dr15Jones, @smuzaffar, @fabiocos, @kpedro88 can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

makortel commented 5 years ago

I gave a quick look what it would mean to use a Modifier to enable the playback mode, but that is impractical because of #25922.

makortel commented 5 years ago

A relatively simple option would be to delete only those aliases that point to mix, but that would still keep these customizations bolt in the ConfigBuilder.

Dr15Jones commented 5 years ago

assign simulation, core

cmsbuild commented 5 years ago

New categories assigned: core,simulation

@Dr15Jones,@smuzaffar,@civanch,@mdhildreth you have been requested to review this Pull request/Issue and eventually sign? Thanks