cms-sw / cmssw

CMS Offline Software
http://cms-sw.github.io/
Apache License 2.0
1.08k stars 4.32k forks source link

Hide all differences between mix and mixData with EDAliases #26001

Open makortel opened 5 years ago

makortel commented 5 years ago

Currently the differences in sim digi (etc) module labels between classical mixing (mix) and premixing (mixData) are partially hidden from downstream modules by the aliases defined in https://github.com/cms-sw/cmssw/blob/master/SimGeneral/MixingModule/python/aliases_cfi.py https://github.com/cms-sw/cmssw/blob/master/SimGeneral/MixingModule/python/aliases_PreMix_cfi.py

These aliases should be extended to cover all outputs of mix and mixData, so that the downstream modules would not have to be customized with premix_stage2 modifier.

cmsbuild commented 5 years ago

A new Issue was created by @makortel Matti Kortelainen.

@davidlange6, @Dr15Jones, @smuzaffar, @fabiocos, @kpedro88 can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

Dr15Jones commented 5 years ago

assign simulation

cmsbuild commented 5 years ago

New categories assigned: simulation

@civanch,@mdhildreth you have been requested to review this Pull request/Issue and eventually sign? Thanks

kpedro88 commented 5 years ago

+infinity