search

cms-sw / cmssw

CMS Offline Software
http://cms-sw.github.io/
Apache License 2.0
1.08k stars 4.29k forks source link

Fix Polycone definitions that have duplicate planes #28634

Open cvuosalo opened 4 years ago

cvuosalo commented 4 years ago

Certain Run 1 scenarios have Polycone definitions in their XML files with duplicate planes. These definitions in the XML files need to be changed so the z/rMin/rMax sections are unique. This problem appeared because ROOT now considers these duplicate planes a bug.

cmsbuild commented 4 years ago

A new Issue was created by @cvuosalo Carl Vuosalo.

@davidlange6, @Dr15Jones, @smuzaffar, @fabiocos, @kpedro88 can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

cvuosalo commented 4 years ago

@ianna Could you please add more information to this issue? Do you know which files have to be changed?

cvuosalo commented 4 years ago

assign geometry

cmsbuild commented 4 years ago

New categories assigned: geometry

@Dr15Jones,@cvuosalo,@mdhildreth,@ianna,@civanch you have been requested to review this Pull request/Issue and eventually sign? Thanks

civanch commented 2 years ago

@cvuosalo , if we do not want to change Run-1 XML how we can solve this issue?

cvuosalo commented 2 years ago

@civanch A plan for Runs 1-2 DD4hep migration would be to convert the Runs 1-2 big XML files into a format suitable for DD4hep (in particular, retaining the names of the SpecPars). A simple fix like deleting duplicate Polycone planes could also be done. The Run 1 XML may not have to be touched, depending on how the conversion is performed.

This issue should be kept open to remind us to check for these duplicate planes when the Run 1 DD4hep migration is done.