search

cms-sw / cmssw

CMS Offline Software
http://cms-sw.github.io/
Apache License 2.0
1.06k stars 4.25k forks source link

Use <charconv> for ParameterSet conversion when it becomes available #30917

Open Dr15Jones opened 3 years ago

Dr15Jones commented 3 years ago

C++17 added a new header which includes the ability to safely convert floating points to/from chars in a completely reproducible way. The mechanism also guarantees the shortest possible representation of the chars which will completely reproduce the floating point number. Such behavior is exactly what we'd like to encode/decode doubles in ParameterSets.

The problem is none of the compilers we use implement that part of the standard. The trunk of gcc evidently does and there is an open source implementation from Microsoft (which is said to be blazingly fast).

Dr15Jones commented 3 years ago

assign core

cmsbuild commented 3 years ago

New categories assigned: core

@Dr15Jones,@smuzaffar,@makortel you have been requested to review this Pull request/Issue and eventually sign? Thanks

cmsbuild commented 3 years ago

A new Issue was created by @Dr15Jones Chris Jones.

@Dr15Jones, @dpiparo, @silviodonato, @smuzaffar, @makortel, @qliphy can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here