search

cms-sw / cmssw

CMS Offline Software
http://cms-sw.github.io/
Apache License 2.0
1.08k stars 4.3k forks source link

libCheck column in IB pages? #31247

Closed davidlange6 closed 4 years ago

davidlange6 commented 4 years ago

What is the source of the libCheck column in the IBs? I did a spot check of one reported error, and don't agree with it. Does the tool consider link and header dependencies?

cmsbuild commented 4 years ago

A new Issue was created by @davidlange6 David Lange.

@Dr15Jones, @dpiparo, @silviodonato, @smuzaffar, @makortel, @qliphy can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

Dr15Jones commented 4 years ago

assign core

cmsbuild commented 4 years ago

New categories assigned: core

@Dr15Jones,@smuzaffar,@makortel you have been requested to review this Pull request/Issue and eventually sign? Thanks

smuzaffar commented 4 years ago

@davidlange6 , the information is obtained by running ldd -u -r libName.so [a]

[a] https://github.com/cms-sw/cmssw/blob/master/Utilities/ReleaseScripts/scripts/libchecker.pl#L42

davidlange6 commented 4 years ago

Thanks — So no, it doesn’t capture header-only dependencies that scram requires also to be expressed via BuildFiles. Perhaps this is not a good metric then?

smuzaffar commented 4 years ago

this basically tells that there is no need to link against a library as it is not directly needed. But if we know that dependency is needed so that scram can correctly generate modules then one should change

<use name="Subsystem/Package"/>

to

<use name="Subsystem/Package" source_only="1"/>
davidlange6 commented 4 years ago

Ah - too bad - when last I asked about a way to do header only dependencies, the solution was just to add them to the build file. So the opportunity to do it correctly is lost for a lot of places.

On Aug 26, 2020, at 4:42 PM, Malik Shahzad Muzaffar notifications@github.com<mailto:notifications@github.com> wrote:

this basically tells that there is no need to link against a library as it is not directly needed. But if we know that dependency is needed so that scram can correctly generate modules then one should change

to

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/cms-sw/cmssw/issues/31247#issuecomment-680923917, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABGPFQZPEOUWB7DSEAP6GPTSCUNO3ANCNFSM4QLOFPYA.

smuzaffar commented 4 years ago

closing it, question has been answered