(A subset of) unused (header) files in cmssw

davidlange6 commented 4 years ago

I made a small search for unused code in cmssw. I found the list below (I'm certain another pass through is needed..). I'd like to make a PR with any files on this list not thought to be needed.. Please comment on anything that is still useful in some form (of course GitHub has the history ...)

Bugs aside.... "unused" means not used by anything that is compiled by the cmssw build. In cases where I found a header used only by an unused test or bin, I tried to list both the header and the used test/bin source.

Alignment/LaserAlignment/interface/OrderedLaserHitPair.h Alignment/LaserAlignment/interface/OrderedLaserHitPairs.h Alignment/LaserAlignment/interface/SeedLayerPairs.h Alignment/MuonAlignmentAlgorithms/interface/MuonInfoTuple.h CalibCalorimetry/EcalLaserAnalyzer/interface/TMCORLin.h CalibCalorimetry/EcalLaserAnalyzer/interface/TMCORSat.h CalibCalorimetry/EcalLaserAnalyzer/interface/TMCReader.h CalibCalorimetry/EcalLaserAnalyzer/interface/TMConfig.h CalibCalorimetry/EcalLaserAnalyzer/interface/TMEGeom.h CalibCalorimetry/EcalLaserAnalyzer/interface/TPEDestalAnalysis.h CalibCalorimetry/HcalAlgos/interface/DoublePadeDelay.h CalibCalorimetry/HcalAlgos/interface/equalADCSignalTime.h CalibFormats/SiPixelObjects/interface/PixelAliasList.h CalibFormats/SiPixelObjects/interface/PixelConfig.h CalibFormats/SiPixelObjects/interface/PixelConfigAlias.h CalibFormats/SiPixelObjects/interface/PixelConfigFile.h CalibFormats/SiPixelObjects/interface/PixelConfigList.h CalibFormats/SiPixelObjects/interface/PixelMaskOverride.h CalibFormats/SiPixelObjects/interface/PixelTrimOverride.h CalibFormats/SiPixelObjects/interface/PixelVersionAlias.h CalibMuon/CSCCalibration/interface/CSCFakeCrosstalkMap.h CalibMuon/CSCCalibration/interface/CSCFakeDBCrosstalkPopCon.h CalibMuon/CSCCalibration/interface/CSCFakeDBGainsPopCon.h CalibTracker/SiStripCommon/interface/SiStripBFieldFilter.h Calibration/IsolatedParticles/interface/CaloSimInfoExtra.h Calibration/IsolatedParticles/interface/eECALMatrixExtra.h Calibration/Tools/interface/TrackDetMatchInfoCollection.h Calibration/Tools/interface/smartSelector.h CommonTools/CandAlgos/interface/CloneProducer.h CommonTools/CandUtils/interface/CandMatcher.h CommonTools/CandUtils/interface/FastCandMatcher.h CommonTools/CandUtils/interface/NamedCandCombiner.h CommonTools/ParticleFlow/interface/ObjectSelector.h CommonTools/ParticleFlow/interface/ObjectSelectors.h CommonTools/Statistics/interface/BinomialProbability.h CommonTools/UtilAlgos/interface/DummyMatchSelector.h CommonTools/UtilAlgos/interface/MassMinSelector.h CommonTools/UtilAlgos/interface/MassRangeSelector.h CommonTools/UtilAlgos/interface/MinSelector.h CommonTools/UtilAlgos/interface/ObjectPairFilter.h CommonTools/UtilAlgos/interface/ObjectRefVectorSelector.h CommonTools/UtilAlgos/interface/OrPairSelector.h CommonTools/Utils/interface/Angle.h CommonTools/Utils/interface/InvariantMass.h CommonTools/Utils/interface/LazyResult.h CommonTools/Utils/interface/MassMinSelector.h CommonTools/Utils/interface/MassRangeSelector.h CommonTools/Utils/interface/MinSelector.h CommonTools/Utils/interface/OrPairSelector.h CondCore/DTPlugins/interface/DTCompactMapPluginHandler.h CondCore/DTPlugins/interface/DTConfigPluginHandler.h CondFormats/CastorObjects/interface/AllClasses.h CondFormats/Common/interface/Constants.h CondFormats/DataRecord/interface/SiStripBadChannelRcd.h CondFormats/DataRecord/interface/SiStripBadFiberRcd.h CondFormats/DataRecord/interface/SiStripBadModuleRcd.h CondFormats/DataRecord/interface/SiStripModuleHVRcd.h CondFormats/DataRecord/interface/SiStripPerformanceSummaryRcd.h CondFormats/DataRecord/interface/SiStripRunSummaryRcd.h CondFormats/HcalObjects/interface/HcalItemArrayColl.h CondFormats/HcalObjects/interface/HcalItemArrayCollById.h CondFormats/Serialization/interface/eos/polymorphic_portable_archive.hpp CondFormats/Serialization/interface/eos/portable_archive.hpp CondFormats/SiPixelObjects/interface/MapPathTodetUnit.h CondTools/Ecal/interface/EcalIntercalibConstantsHandler.h CondTools/Ecal/interface/EcalIntercalibConstantsMCHandler.h CondTools/Ecal/interface/EcalIntercalibErrorsHandler.h CondTools/Ecal/interface/EcalIntercalibErrorsXMLTranslator.h CondTools/Ecal/interface/EcalPFRecHitThresholdsXMLTranslator.h CondTools/Ecal/interface/EcalTimeCalibConstantsHandler.h CondTools/Ecal/interface/EcalTimeCalibConstantsXMLTranslator.h CondTools/Ecal/interface/EcalTimeCalibErrorsHandler.h CondTools/Ecal/interface/EcalTimeCalibErrorsXMLTranslator.h CondTools/Ecal/test/testXMLTranslators.cc CondTools/L1Trigger/interface/Interval.h CondTools/RPC/interface/L1RPCHwConfigDBWriter.h CondTools/RPC/interface/RPCEMapDBWriter.h CondTools/SiStrip/interface/SiStripCondObjBuilderBase.h CondTools/SiStrip/interface/SiStripDepCondObjBuilderBase.h DQM/HcalCommon/interface/ContainerD.h DQM/HcalTasks/interface/TestTask.h DQMOffline/JetMET/interface/GlobalVariables.h DQMOffline/JetMET/interface/SusyDQM/GenericPlotter.h DQMOffline/JetMET/interface/SusyDQM/Indexed.h DQMOffline/JetMET/interface/SusyDQM/Overlayer.h DQMOffline/JetMET/interface/SusyDQM/round_string.h DataFormats/BTauReco/interface/PFCombinedTauTagInfo.h DataFormats/BTauReco/interface/PFIsolatedTauTagInfo.h DataFormats/BTauReco/interface/TrackIPData.h DataFormats/Common/interface/NewPolicy.h DataFormats/Common/interface/OwnArray.h DataFormats/Common/interface/TransientDataFrame.h DataFormats/Common/interface/debugging_allocator.h DataFormats/Common/test/OwnArray_t.cpp DataFormats/Common/test/testOwnArray.cc DataFormats/GeometrySurface/interface/private/extTkRotation.h DataFormats/GeometrySurface/interface/private/newTkRotation.h DataFormats/GeometrySurface/interface/private/oldTkRotation.h DataFormats/GeometryVector/interface/OnePiRange.h DataFormats/GeometryVector/interface/private/extBasic2DVector.h DataFormats/GeometryVector/interface/private/oldBasic2DVector.h DataFormats/GeometryVector/interface/private/oldBasic3DVector.h DataFormats/METReco/interface/PFClusterMETCollection.h DataFormats/Math/interface/SSEArray.h DataFormats/Math/interface/private/AVXVec.h DataFormats/ParticleFlowReco/interface/PFBlockElementFwd.h DataFormats/ParticleFlowReco/interface/PFBlockElementSuperClusterFwd.h DataFormats/ParticleFlowReco/interface/PFClusterShapeAssociation.h DataFormats/ParticleFlowReco/interface/PFParticleFwd.h DataFormats/ParticleFlowReco/interface/PFSuperClusterFwd.h DataFormats/ParticleFlowReco/interface/PFTrajectoryPointFwd.h DataFormats/Provenance/interface/BranchDescriptionIndex.h DataFormats/Provenance/interface/TypeInBranchType.h DataFormats/RPCDigi/interface/RPCDigiL1Linkfwd.h DataFormats/SiPixelDigi/interface/PixelDigiCollectionfwd.h DataFormats/SiStripCluster/interface/SiStripClusterfwd.h DataFormats/SiStripCommon/interface/ConstantsForSummaryPlots.h DataFormats/SiStripDigi/interface/SiStripDigifwd.h DataFormats/TrackerRecHit2D/interface/SiPixelRecHitfwd.h DataFormats/TrajectorySeed/interface/BasicTrajectorySeed.h DetectorDescription/Core/interface/DDPath.h DetectorDescription/Core/interface/DDRegistry.h DetectorDescription/RegressionTest/interface/DDExpandedViewDump.h ElectroWeakAnalysis/WENu/interface/GenPurposeSkimmer.h ElectroWeakAnalysis/WENu/interface/GenPurposeSkimmerAcceptance.h ElectroWeakAnalysis/ZEE/interface/AnalysisErsatz.h ElectroWeakAnalysis/ZMuMu/bin/csa08IsoBkg.cpp ElectroWeakAnalysis/ZMuMu/bin/csa08ZFit.cpp ElectroWeakAnalysis/ZMuMu/bin/zMassFit.cpp ElectroWeakAnalysis/ZMuMu/bin/zMassHSFit.cpp ElectroWeakAnalysis/ZMuMu/bin/zMassMCFit.cpp ElectroWeakAnalysis/ZMuMu/bin/zMassResFit.cpp ElectroWeakAnalysis/ZMuMu/bin/zMuMuExpFit.cpp ElectroWeakAnalysis/ZMuMu/bin/zMuMuFit.cpp ElectroWeakAnalysis/ZMuMu/bin/zToMuMuMassMCFit.cpp EventFilter/DTRawToDigi/interface/DTROS25Data.h EventFilter/ESRawToDigi/interface/ESCrcKchipFast.h EventFilter/EcalRawToDigi/interface/ECALUnpackerException.h EventFilter/EcalRawToDigi/interface/MyWatcher.h EventFilter/RPCRawToDigi/interface/RPCRawSynchro.h EventFilter/Utilities/interface/ModuleWeb.h EventFilter/Utilities/interface/config_json.h FWCore/ServiceRegistry/interface/TypeInfoHolder.h GeneratorInterface/TauolaInterface/interface/TauolaWrapper.h Geometry/CaloGeometry/interface/EZMgrVL.h Geometry/CommonDetUnit/interface/DetPositioner.h Geometry/CommonDetUnit/interface/ModifiedSurfaceGenerator.h Geometry/CommonDetUnit/interface/MuonGeomDet.h HeavyFlavorAnalysis/SpecificDecay/interface/BPHMuonChargeSelect.h HeavyFlavorAnalysis/SpecificDecay/interface/BPHParticleChargeSelect.h IOPool/Common/interface/CustomStreamer.h JetMETCorrections/InterpolationTables/interface/BoxNDScanner.h JetMETCorrections/InterpolationTables/interface/MultivariateFunctorScanner.h JetMETCorrections/InterpolationTables/interface/rescanArray.h JetMETCorrections/Type1MET/interface/CorrectedMETProducerT.h L1Trigger/CSCCommonTrigger/interface/vmac.h L1Trigger/DTSectorCollector/interface/DTSCCand.h L1Trigger/GlobalCaloTrigger/interface/L1GctSimpleJetFinder.h L1Trigger/L1TCalorimeter/interface/classes.h L1Trigger/L1TMuonOverlap/interface/OMTFConfigurator.h L1Trigger/L1TMuonOverlap/interface/OMTFPatternMaker.h L1Trigger/L1TNtuples/interface/L1AnalysisRecoTrackBase.h L1TriggerOffline/L1Analyzer/interface/L1PromptAnalysis.h MagneticField/Engine/interface/MagneticFieldHelpers.h MagneticField/VolumeGeometry/interface/RectangularVolumeBounds.h Mixing/Base/interface/FixedPUGenerator.h Mixing/Base/interface/PUGenerator.h OnlineDB/CSCCondDB/interface/AutoCorrMat.h OnlineDB/CSCCondDB/interface/CSCCableReadTest.h OnlineDB/CSCCondDB/interface/CSCxTalk.h OnlineDB/CSCCondDB/interface/SaturationFcn.h OnlineDB/CSCCondDB/interface/SaturationFit.h OnlineDB/EcalCondDB/interface/IConfig.h OnlineDB/EcalCondDB/interface/IRunIOV.h OnlineDB/EcalCondDB/interface/ITimeIOV.h OnlineDB/EcalCondDB/interface/all_cali_types.h OnlineDB/EcalCondDB/interface/all_dcu_types.h OnlineDB/EcalCondDB/interface/all_mod_types.h OnlineDB/EcalCondDB/test/InsertDCUIdarkPed.cpp OnlineDB/EcalCondDB/test/TestChannelView.cpp OnlineDB/EcalCondDB/test/TestDCU.cpp OnlineDB/EcalCondDB/test/TestMOD.cpp PhysicsTools/FWLite/interface/WSelectorFast.h PhysicsTools/MVAComputer/interface/MVAModuleHelper.h PhysicsTools/PatExamples/interface/WPlusJetsEventSelector.h PhysicsTools/PatUtils/interface/JetSelector.h PhysicsTools/PatUtils/interface/JetSelector.icc PhysicsTools/PatUtils/interface/PatSelectorByFlags.h PhysicsTools/PatUtils/interface/RefHelper.h PhysicsTools/SelectorUtils/interface/Variables.h PhysicsTools/UtilAlgos/interface/DummyMatchSelector.h PhysicsTools/UtilAlgos/interface/EventSelector.h PhysicsTools/UtilAlgos/interface/MCMatchSelector.h PhysicsTools/UtilAlgos/interface/NtpProducer.h PhysicsTools/UtilAlgos/interface/SelectedOutputCollectionTrait.h PhysicsTools/UtilAlgos/interface/SelectionAdderTrait.h PhysicsTools/UtilAlgos/interface/StoreContainerTrait.h PhysicsTools/UtilAlgos/interface/TwoObjectCalculator.h PhysicsTools/Utilities/interface/GammaPropagator.h PhysicsTools/Utilities/interface/GammaZInterference.h PhysicsTools/Utilities/interface/Number.h PhysicsTools/Utilities/interface/ZLineShape.h RecoEcal/EgammaClusterProducers/interface/PiZeroDiscriminatorProducer.h RecoEgamma/EgammaTools/interface/ConversionTools.h RecoEgamma/EgammaTools/interface/EffectiveAreas.h RecoHI/HiJetAlgos/interface/UECalibration.h RecoJets/JetAnalyzers/doc/myJetAna.html RecoJets/JetAnalyzers/interface/CaloTowerBoundries.h RecoJets/JetAnalyzers/interface/MyCluster.h RecoJets/JetAnalyzers/interface/myFilter.h RecoJets/JetAnalyzers/interface/myJetAna.h RecoJets/JetAnalyzers/test/myFilter.cc RecoJets/JetAnalyzers/test/myJetAna.cc RecoLocalCalo/EcalRecAlgos/interface/EcalUncalibRecHitLeadingEdgeAlgo.h RecoMuon/TrackingTools/interface/MuonSeedDetLayer.h RecoTracker/SpecialSeedGenerators/interface/EtaPhiMeasurementEstimator.h RecoTracker/TkMSParametrization/interface/rangesIntersect.h RecoTracker/TrackProducer/interface/GsfTrackProducerAlgorithm.h RecoTracker/TransientTrackingRecHit/interface/GSTransientTrackingRecHit.h RecoVertex/ConfigurableVertexReco/interface/ReconstructorFromLinPtFinder.h RecoVertex/KinematicFit/interface/CombinedKinematicConstraintT.h RecoVertex/LinearizationPointFinders/interface/MonteCarloLinearizationPointFinder.h RecoVertex/LinearizationPointFinders/src/MonteCarloLinearizationPointFinder.cc SimCalorimetry/CaloSimAlgos/interface/CaloVNoisifier.h SimDataFormats/RPCDigiSimLink/interface/RPCDigiSimLinkfwd.h SimDataFormats/TrackerDigiSimLink/interface/PixelDigiSimLinkfwd.h SimDataFormats/TrackerDigiSimLink/interface/StripCompactDigiSimLinksfwd.h SimDataFormats/TrackerDigiSimLink/interface/StripDigiSimLinkfwd.h SimG4CMS/Calo/interface/HcalTestHistoClass.h SimG4Core/Application/interface/DDDWorldObserver.h SimG4Core/Notification/interface/ComponentBuilder.h SimG4Core/Notification/interface/ComponentFactoryByName.h SimG4Core/Notification/interface/DispatchableG4Step.h SimG4Core/Notification/interface/OwnIt.h TopQuarkAnalysis/TopTools/interface/TopologyWorker.h TrackingTools/AnalyticalJacobians/interface/CurvilinearJacobian.h TrackingTools/GsfTools/interface/GaussianSumUtilities.h TrackingTools/GsfTools/interface/GaussianSumUtilities.icc TrackingTools/PatternTools/interface/MediumProperties.h TrackingTools/Records/interface/Records.h

cmsbuild commented 4 years ago

A new Issue was created by @davidlange6 David Lange.

@Dr15Jones, @dpiparo, @silviodonato, @smuzaffar, @makortel, @qliphy can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

makortel commented 4 years ago

assign alca, analysis, reconstruction, dqm, core, simulation, geometry, l1

(did I miss any?)

cmsbuild commented 4 years ago

New categories assigned: core,geometry,analysis,simulation,reconstruction,l1,dqm,alca

@Dr15Jones,@Dr15Jones,@smuzaffar,@cvuosalo,@mdhildreth,@mdhildreth,@jfernan2,@slava77,@benkrikler,@christopheralanwest,@andrius-k,@fioriNTU,@tlampen,@pohsun,@santocch,@rekovic,@perrotta,@makortel,@makortel,@jpata,@tocheng,@kmaeshima,@ianna,@ErnestaP,@civanch,@civanch you have been requested to review this Pull request/Issue and eventually sign? Thanks

makortel commented 4 years ago

assign db

(yes I did)

cmsbuild commented 4 years ago

New categories assigned: db

@ggovi you have been requested to review this Pull request/Issue and eventually sign? Thanks

makortel commented 4 years ago

assign daq

cmsbuild commented 4 years ago

New categories assigned: daq

@smorovic,@emeschi you have been requested to review this Pull request/Issue and eventually sign? Thanks

makortel commented 4 years ago

assign generators

cmsbuild commented 4 years ago

New categories assigned: generators

@alberto-sanchez,@SiewYan,@GurpreetSinghChahal,@mkirsano,@agrohsje you have been requested to review this Pull request/Issue and eventually sign? Thanks

davidlange6 commented 4 years ago

as far as I see, commits in the last 4 years affecting this files that were possibly not technical migrations are

CondTools/Ecal/interface/EcalPFRecHitThresholdsXMLTranslator.h 76d8a578b9b - Stefano Argiro, 2 years, 7 months ago : Initial commit for new PF threshold DB object DetectorDescription/Core/interface/DDRegistry.h bdf08d0ca77 - Ianna Osborne, 3 years, 3 months ago : Merge Base to Core JetMETCorrections/Type1MET/interface/CorrectedMETProducerT.h 8b8f0e2bf26 - Ben Jones, 9 weeks ago : removed unnessecary argument of EventSetup

smorovic commented 4 years ago

+1 (for DAQ) - two headers, both in EventFilter/Utilities, are obsolete

lwang046 commented 4 years ago

DQM/HcalCommon/interface/ContainerD.h DQM/HcalTasks/interface/TestTask.h

The two headers for hcal dqm are test codes and never used after creation. Can be safely removed.

cvuosalo commented 4 years ago

The entirety of DetectorDescription/Core and DetectorDescription/RegressionTest is intended to be deleted next year. It doesn't really matter if some obsolete files within these packages are deleted now.

slava77 commented 4 years ago

the list is too long to have an immediate response, I expect that all individual packages will need to be checked separately with corresponding groups; it may not be practical to tag 20+ reco contacts here.

jfernan2 commented 3 years ago

DQM/HcalCommon/interface/ContainerD.h DQM/HcalTasks/interface/TestTask.h

The two headers for hcal dqm are test codes and never used after creation. Can be safely removed.

After confirming also by @iatakisi privately that also JetMET headers are safe to be deleted, I have created the following PR with the removal:

https://github.com/cms-sw/cmssw/pull/31790

jfernan2 commented 3 years ago

+1

ianna commented 3 years ago

Geometry/CaloGeometry/interface/EZMgrVL.h Geometry/CommonDetUnit/interface/DetPositioner.h Geometry/CommonDetUnit/interface/ModifiedSurfaceGenerator.h Geometry/CommonDetUnit/interface/MuonGeomDet.h

indeed they are not used. The last three have been migrated to another package. The PR https://github.com/cms-sw/cmssw/pull/31793 deletes them.

agrohsje commented 3 years ago

Indeed: GeneratorInterface/TauolaInterface/interface/TauolaWrapper.h is not needed anymore. @mkirsano @siewyan please comment in case you see a reason to keep. @davidlange6 Should we make a PR to delete or will we handle centrally?

ianna commented 3 years ago

DetectorDescription/Core/interface/DDPath.h DetectorDescription/Core/interface/DDRegistry.h DetectorDescription/RegressionTest/interface/DDExpandedViewDump.h

Indeed these are not used. Addressed in https://github.com/cms-sw/cmssw/pull/31804

ianna commented 3 years ago

+1

done for DetectorDescription and Geometry. Thanks @davidlange6 !