search

cms-sw / cmssw

CMS Offline Software
http://cms-sw.github.io/
Apache License 2.0
1.09k stars 4.33k forks source link

Relocate algos from DataFormats/CaloRecHit, clean up for coding rules #32159

Open jpata opened 4 years ago

jpata commented 4 years ago

The Patatrack PRs #31704 and #32144 introduced calo-specific maths functionality depending on Eigen into DataFormats/CaloRecHit.

It was pointed out in https://github.com/cms-sw/cmssw/pull/32144#issuecomment-727835386 and elsewhere that if it's just algorithms and not actual data formats, it might suit better in e.g. RecoLocalCalo/CommonAlgos or CommonTools/RecoAlgos. In addition, there is ongoing discussion in #31735 to remove the Eigen dependency from DataFormats.

Since the Patatrack PRs are still in flux, the proposal would be to address this post-Patatrack-integration, once it becomes more clear what methods and dataformats are actually brought in and are common between the PRs and between the CPU & GPU codes.

In addition, there are coding rules violations which slipped through (single character variable names, uppercase variables), these should be addressed.

cmsbuild commented 4 years ago

A new Issue was created by @jpata Joosep Pata.

@Dr15Jones, @dpiparo, @silviodonato, @smuzaffar, @makortel, @qliphy can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

jpata commented 4 years ago

assign reconstruction, heterogeneous

cmsbuild commented 4 years ago

New categories assigned: heterogeneous,reconstruction

@slava77,@perrotta,@makortel,@jpata,@fwyzard you have been requested to review this Pull request/Issue and eventually sign? Thanks