Closed silviodonato closed 3 years ago
assign reconstruction
New categories assigned: reconstruction
@slava77,@perrotta,@jpata you have been requested to review this Pull request/Issue and eventually sign? Thanks
A new Issue was created by @silviodonato Silvio Donato.
@Dr15Jones, @dpiparo, @silviodonato, @smuzaffar, @makortel, @qliphy can you please review it and eventually sign/assign? Thanks.
cms-bot commands are listed here
fixed by #33069
Sorry, I missed the notification somehow. For my education, how come the unit test didn't fail in the bot tests of the original PR (link)? Is it because checkdeps didn't pick up Configuration/DataProcessing, and it only came up in the build process?
Is it because checkdeps didn't pick up Configuration/DataProcessing, and it only came up in the build process?
Correct. Configuration/DataProcessing
appears to have no direct dependence on the files changed in #33069 and therefore the machinery behind git cms-checkdeps -a
was unaware of the impact. (this is similar to other deficiencies in the testing system that have been discussed earlier, but this would be hard to fix in general without lot's of manual maintenance or running all unit tests; so far the problems appear to be infrequent-enough for catching them in IBs to be sufficient)
A unit test is failing in
Configuration/DataProcessing
after having merged #33024 . @jpata could you have a look?