search

cms-sw / cmssw

CMS Offline Software
http://cms-sw.github.io/
Apache License 2.0
1.08k stars 4.31k forks source link

CPU speedup opportunity ConvBremPFTrackFinder::runConvBremFinder #34289

Closed slava77 closed 4 months ago

slava77 commented 3 years ago

as seen in https://cms-reco-profiling.web.cern.ch/cms-reco-profiling/cgi-bin/igprof-navigator/releases/CMSSW_12_0_0_pre3/23434.21/step3/cpu_endjob/366 about 0.3% of the reco workflow time in PU200 is taken by eta, phi calls (evident in cost counts as log and atan). ConvBremPFTrackFinder::runConvBremFinder https://github.com/cms-sw/cmssw/blob/CMSSW_12_0_0_pre3/RecoParticleFlow/PFTracking/src/ConvBremPFTrackFinder.cc#L33 is called by PFElecTkProducer::produce in a loop over GSF tracks https://github.com/cms-sw/cmssw/blob/CMSSW_12_0_0_pre3/RecoParticleFlow/PFTracking/plugins/PFElecTkProducer.cc#L363-L375

All data relevant to PFRecTrackCollection is recomputed. The speedup can be achieved by caching the relevant values (pt, eta, phi) and passing them to ConvBremPFTrackFinder::runConvBremFinder for faster reuse.

@laurenhay @marksan87

slava77 commented 3 years ago

assign reconstruction

cmsbuild commented 3 years ago

New categories assigned: reconstruction

@slava77,@perrotta,@jpata you have been requested to review this Pull request/Issue and eventually sign? Thanks

cmsbuild commented 3 years ago

A new Issue was created by @slava77 Slava Krutelyov.

@Dr15Jones, @dpiparo, @silviodonato, @smuzaffar, @makortel, @qliphy can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

jpata commented 2 years ago

@gartung this could be a good target for a purely technical optimization to address by the upgrade R&D and CMP

jpata commented 2 years ago

type performance-improvements

jpata commented 2 years ago

@laurenhay @marksan87 please take note of this performance improvement possibility and let us know if this can be addressed.

https://github.com/orgs/cms-sw/teams/pf-l2

jpata commented 2 years ago

In http://cms-reco-profiling.web.cern.ch/cms-reco-profiling/cgi-bin/igprof-navigator/releases/CMSSW_12_4_0_pre1/35234.21/step3/cpu_endjob/1379 it looks more like 0.15% in log/atan2, 0.21% in ConvBremPFTrackFinder.

jpata commented 2 years ago

type pf

mandrenguyen commented 1 year ago

@laurenhay @marksan87 Kicking the tires on this old issue. Perhaps something for your New Year's resolutions?

swagata87 commented 1 year ago

trying some cleanups here: https://github.com/cms-sw/cmssw/pull/42984 tagging also @bellan

stahlleiton commented 4 months ago

@cms-sw/reconstruction-l2 : Is this issue fully addressed by https://github.com/cms-sw/cmssw/pull/42984 or is something still pending to close it?

cmsbuild commented 4 months ago

cms-bot internal usage

mandrenguyen commented 4 months ago

+1

cmsbuild commented 4 months ago

This issue is fully signed and ready to be closed.

stahlleiton commented 4 months ago

Would be appreciated if someone could close this issue. Thanks.

mandrenguyen commented 4 months ago

please close