search

cms-sw / cmssw

CMS Offline Software
http://cms-sw.github.io/
Apache License 2.0
1.08k stars 4.29k forks source link

[TSAN] warning: 'muonPosition' may be used uninitialized in this function in PATMuonProducer.cc #35621

Open iarspider opened 3 years ago

iarspider commented 3 years ago

Log file

src/DataFormats/GeometryVector/interface/private/sseBasic3DVector.h: In member function 'void pat::PATMuonProducer::fillL1TriggerInfo(pat::Muon&, edm::Handle<std::vector<pat::TriggerObjectStandAlone> >&, const edm::TriggerNames&, const edm::ESHandle<GlobalTrackingGeometry>&)':
  src/DataFormats/GeometryVector/interface/private/sseBasic3DVector.h:15:41: warning: '*((void*)& muonPosition +8)' may be used uninitialized in this function [-Wmaybe-uninitialized]
    15 |     float t(z / std::sqrt(x * x + y * y));
      |                                         ^
src/PhysicsTools/PatAlgos/plugins/PATMuonProducer.cc:506:30: note: '*((void*)& muonPosition +8)' was declared here
  506 |   std::optional<GlobalPoint> muonPosition;
      |                              ^~~~~~~~~~~~
In file included from src/DataFormats/GeometryVector/interface/Basic3DVector.h:9,
                 from src/DataFormats/GeometryVector/interface/PV3DBase.h:4,
                 from src/DataFormats/GeometryVector/interface/Vector3DBase.h:5,
                 from src/DataFormats/GeometryVector/interface/GlobalVector.h:5,
                 from src/DataFormats/Candidate/interface/ParticleState.h:16,
                 from src/DataFormats/Candidate/interface/Particle.h:13,
                 from src/DataFormats/Candidate/interface/Candidate.h:19,
                 from src/DataFormats/Candidate/interface/LeafCandidate.h:11,
                 from src/DataFormats/Candidate/interface/CompositeRefCandidateT.h:13,
                 from src/DataFormats/HepMCCandidate/interface/GenParticle.h:10,
                 from src/PhysicsTools/PatAlgos/plugins/PATMuonProducer.cc:15:
  src/DataFormats/GeometryVector/interface/private/sseBasic3DVector.h:15:37: warning: '*((void*)& muonPosition +4)' may be used uninitialized in this function [-Wmaybe-uninitialized]
    15 |     float t(z / std::sqrt(x * x + y * y));
      |                                   ~~^~~
src/PhysicsTools/PatAlgos/plugins/PATMuonProducer.cc:506:30: note: '*((void*)& muonPosition +4)' was declared here
  506 |   std::optional<GlobalPoint> muonPosition;
      |                              ^~~~~~~~~~~~
In file included from src/DataFormats/GeometryVector/interface/Basic3DVector.h:9,
                 from src/DataFormats/GeometryVector/interface/PV3DBase.h:4,
                 from src/DataFormats/GeometryVector/interface/Vector3DBase.h:5,
                 from src/DataFormats/GeometryVector/interface/GlobalVector.h:5,
                 from src/DataFormats/Candidate/interface/ParticleState.h:16,
                 from src/DataFormats/Candidate/interface/Particle.h:13,
                 from src/DataFormats/Candidate/interface/Candidate.h:19,
                 from src/DataFormats/Candidate/interface/LeafCandidate.h:11,
                 from src/DataFormats/Candidate/interface/CompositeRefCandidateT.h:13,
                 from src/DataFormats/HepMCCandidate/interface/GenParticle.h:10,
                 from src/PhysicsTools/PatAlgos/plugins/PATMuonProducer.cc:15:
  src/DataFormats/GeometryVector/interface/private/sseBasic3DVector.h:15:29: warning: 'muonPosition' may be used uninitialized in this function [-Wmaybe-uninitialized]
    15 |     float t(z / std::sqrt(x * x + y * y));
      |                           ~~^~~
src/PhysicsTools/PatAlgos/plugins/PATMuonProducer.cc:506:30: note: 'muonPosition' was declared here
  506 |   std::optional<GlobalPoint> muonPosition;
      |
cmsbuild commented 3 years ago

A new Issue was created by @iarspider .

@Dr15Jones, @perrotta, @dpiparo, @makortel, @smuzaffar, @qliphy can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

iarspider commented 3 years ago

assign reconstruction

cmsbuild commented 3 years ago

New categories assigned: reconstruction

@slava77,@jpata you have been requested to review this Pull request/Issue and eventually sign? Thanks

jpata commented 2 years ago

type muon