cms-sw / cmssw

CMS Offline Software
http://cms-sw.github.io/
Apache License 2.0
1.08k stars 4.32k forks source link

harmonize express config settings between DataProcessing scenarios and cmsDriver #35693

Open slava77 opened 3 years ago

slava77 commented 3 years ago

in connection with https://github.com/cms-sw/cmssw/pull/35639#pullrequestreview-780135309

cmsbuild commented 3 years ago

A new Issue was created by @slava77 Slava Krutelyov.

@Dr15Jones, @perrotta, @dpiparo, @makortel, @smuzaffar, @qliphy can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

makortel commented 3 years ago

assign operations

cmsbuild commented 3 years ago

New categories assigned: operations

@fabiocos,@qliphy,@davidlange6,@perrotta you have been requested to review this Pull request/Issue and eventually sign? Thanks

mmusich commented 3 years ago

I've started to take a look to this. I think that one would need to remove the the various

'--customise':'Configuration/DataProcessing/RecoTLR.customise ...'

from Configuration/PyReleaseValidation/python/relval_steps.py and possibly use the ModifierChains available in

https://github.com/cms-sw/cmssw/blob/8411a01d67c9b64efdb40525b8ad132973919a93/Configuration/DataProcessing/python/Modifiers.py#L1-L12

It seems to me - though - that these in order to be usable elsewhere would need to be moved outside of Configuration/DataProcessing and put instead in Configuration/Eras. Would that be acceptable @cms-sw/operations-l2 ?

slava77 commented 3 years ago

'--customise':'Configuration/DataProcessing/RecoTLR.customise ...'

I concluded when introducing these that customisePostEra* should stay; but that was a long time ago. I need to think.

mmusich commented 3 years ago

I concluded when introducing these that customisePostEra* should stay; but that was a long time ago. I need to think.

For the moment I was referring only to customiseExpress (and friends) and customisePrompt (and friends).