Open gartung opened 2 years ago
cmsbuild
commented
2 years ago A new Issue was created by @gartung Patrick Gartung.
@Dr15Jones, @perrotta, @dpiparo, @makortel, @smuzaffar, @qliphy can you please review it and eventually sign/assign? Thanks.
cms-bot commands are listed here
makortel
commented
2 years ago assign l1
cmsbuild
commented
2 years ago New categories assigned: l1
@epalencia,@rekovic,@cecilecaillol you have been requested to review this Pull request/Issue and eventually sign? Thanks
makortel
commented
2 years ago // FIXME AP_AUTOCC cannot handle many standard headers, so declare instead of
// include.
// #include <complex>
namespace std {
template<typename _Tp> class complex;
}The C++ standard says that adding declarations to namespace std leads to undefined behavior (whose implications we observe now). If the AP_AUTOCC (whatever that is) can't handle <complex>, would it be possible to add an #ifdef there to use the (non-standard) forward declaration only when compiling with AP_AUTOCC?
Then how should we do that? I see https://github.com/Xilinx/HLS_arbitrary_Precision_Types has last been updated almost 3 years ago, and has no issues or pull requests. We could fork it to cms-externals and patch it there, but I suppose it could be good to inform Xilinx even then.
An alternative would be to remove the use of hls external from DataFormats/L1TrackTrigger (although the undefined behavior might come back to bite us later in the future).
This line is identified in HLS package header ap_fixed_special.h https://github.com/Xilinx/HLS_arbitrary_Precision_Types/blob/200a9aecaadf471592558540dc5a88256cbf880f/include/ap_fixed_special.h#L30 and this line in HLS package header ap_int_special.h https://github.com/Xilinx/HLS_arbitrary_Precision_Types/blob/200a9aecaadf471592558540dc5a88256cbf880f/include/ap_int_special.h#L30
Error message