Open ttedeschi opened 2 years ago
A new Issue was created by @ttedeschi Tommaso Tedeschi.
@Dr15Jones, @perrotta, @dpiparo, @makortel, @smuzaffar, @qliphy can you please review it and eventually sign/assign? Thanks.
cms-bot commands are listed here
assign dqm
assign dqm
New categories assigned: dqm
@jfernan2,@ahmad3213,@micsucmed,@rvenditti,@emanueleusai,@pmandrik you have been requested to review this Pull request/Issue and eventually sign? Thanks
I would comment this line to remove the module until BTV experts solve it:
And bTagHLTTrackMonitoringSequence too since it may depend on the former....
In the provided tarball, executed in single threaded mode, the crash happens at event 200 and it looks like to happen at
https://github.com/cms-sw/cmssw/blob/master/DQMOffline/Trigger/plugins/BTVHLTOfflineSource.cc#L438
likely something wrong with jetSVTagsCollPF
FYI @marco-link @johnalison @JyothsnaKomaragiri @natalia-korneeva @SWuchterl as BTV HLT DQM And Validation Code Developers https://twiki.cern.ch/twiki/bin/viewauth/CMS/DQMContacts#Btag_and_vertexing
BTV HLT DQM developers (@marco-link @terrill37 me) are working on it and can replicate the error.
seems the place in which it fails is at
seems the place in which it fails is at
Indeed, we have implemented a sanity check for null-pointer in the following push_back
calls, which resolves the error.
We are currently preparing the PRs and checking the tests.
We are currently preparing the PRs and checking the tests.
OK. This
diff --git a/DQMOffline/Trigger/plugins/BTVHLTOfflineSource.cc b/DQMOffline/Trigger/plugins/BTVHLTOfflineSource.cc
index 464127097b7..19a013938cc 100644
--- a/DQMOffline/Trigger/plugins/BTVHLTOfflineSource.cc
+++ b/DQMOffline/Trigger/plugins/BTVHLTOfflineSource.cc
@@ -795,6 +795,8 @@ std::vector<const reco::Track*> BTVHLTOfflineSource::getOnlineBTagTracks(float h
unsigned int trackSize = ipInfo.selectedTracks().size();
for (unsigned int itt = 0; itt < trackSize; ++itt) {
const auto ptrackRef = (ipInfo.selectedTracks()[itt]); //TrackRef or
+ if (!ptrackRef.isAvailable())
+ continue;
const reco::Track* ptrackPtr = reco::btag::toTrack(ptrackRef);
onlineTracks.push_back(ptrackPtr);
onlineIP3D.push_back(ip[itt].ip3d.value());
trivially works for me (at least gets past the error), but I am not sure if that's what people want.
Thanks to the people who are debugging.
I'm in favour of a(ny) fix being integrated asap, but it would also be useful to know the reason behind this failure. Is some track collection missing in the input file wrt what the DQM client needs/expects?
Knowing better the reason behind the problem might suggest a workaround that we could apply to the HLT menu to be used online this weekend. This could reduce pressure to deploy a new release online.
Opened the PR. Thanks @mmusich for working on this in parallel (you were ~20 minutes ahead of us :grinning:)
I'll prepare backports for 12_3_X and 12_4_X.
Thanks to the people who are debugging.
I'm in favour of a(ny) fix being integrated asap, but it would also be useful to know the reason behind this failure. Is some track collection missing in the input file wrt what the DQM client needs/expects?
Knowing better the reason behind the problem might suggest a workaround that we could apply to the HLT menu to be used online this weekend. This could reduce pressure to deploy a new release online.
We are still investigating and it is not clear to us which collection is missing. It might be connected to code that is only used by BTV but we will follow up on that.
As pointed out here https://cms-talk.web.cern.ch/t/paused-jobs-for-run-355207-collisions/12561 the following error is encountered when running
express_StreamHLTMonitor
workflow for both runs 355207 and 355208full info can be found here:
/afs/cern.ch/user/c/cmst0/public/PausedJobs/ExpressHLTMonitor/job/WMTaskSpace/cmsRun1
a possible fix, even a temporary one, should be found urgently