cms-sw / cmssw

CMS Offline Software
http://cms-sw.github.io/
Apache License 2.0
1.07k stars 4.29k forks source link

G4e refitter configuration broken by dd4hep #38739

Closed mmusich closed 2 years ago

mmusich commented 2 years ago

Since there are widespread plans of using the G4e refitting technology for both the muon momentum scale calibration for the W mass analysis and for the global tracker alignment procedure, it's important that we start testing it. Unfortunately the current setup is broken, possibly from the dd4hep updates in the configuration. Running the setup put together at PR https://github.com/cms-sw/cmssw/pull/38738 results in:

----- Begin Fatal Exception 14-Jul-2022 14:06:57 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=GeometryProducer label='geopro'
Exception Message:
MissingParameter: Parameter 'g4GeometryDD4hepSource' not found.
----- End Fatal Exception -------------------------------------------------

This was also reported quite some time ago at https://cms-talk.web.cern.ch/t/help-with-running-g4-refit-in-12-4-x/10294 but no replies so far.

mmusich commented 2 years ago

assign geometry, simulation

cmsbuild commented 2 years ago

New categories assigned: geometry,simulation

@mdhildreth,@mdhildreth,@ianna,@Dr15Jones,@makortel,@bsunanda,@civanch,@civanch you have been requested to review this Pull request/Issue and eventually sign? Thanks

mmusich commented 2 years ago

urgent

cmsbuild commented 2 years ago

A new Issue was created by @mmusich Marco Musich.

@Dr15Jones, @perrotta, @dpiparo, @rappoccio, @makortel, @smuzaffar, @qliphy can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

VinInn commented 2 years ago

made progress. try to create geom in beginRun

now I get ----- Begin Fatal Exception 26-Jul-2022 11:39:10 CEST----------------------- An exception of category 'DetectorDescriptionFault' occurred while [0] Processing global begin Run run: 1 [1] Calling method for module GeometryProducer/'geopro' Exception Message: DDG4SolidConverter::convert: conversion failed for s=ebalgo:ESPM ShapelessSolid: shapeless solid.shape()=ShapelessSolid ----- End Fatal Exception -------------------------------------------------

VinInn commented 2 years ago

more progress with

process.GlobalTag = GlobalTag(process.GlobalTag, 'auto:run1_mc', '')

seems to work (in wf 20.0)

at least

cmsRun Geant4e_example_cfg.py

does not crash

tvami commented 2 years ago

This is an issue that's marked urgent and I think already resolved, can it be closed?

mmusich commented 2 years ago

It needs to be signed by the respective L2s

tvami commented 2 years ago

@bsunanda you can now sign for both signatures, no?

civanch commented 2 years ago

+1

cmsbuild commented 2 years ago

This issue is fully signed and ready to be closed.

mmusich commented 2 years ago

closing as resolved in https://github.com/cms-sw/cmssw/pull/38864