cms-sw / cmssw

CMS Offline Software
http://cms-sw.github.io/
Apache License 2.0
1.07k stars 4.29k forks source link

Testing adding `allTrackMCMatch` collection to RelVals #39001

Open tvami opened 2 years ago

tvami commented 2 years ago

I was studying fake tracks in ttbar MC, and I learned that allTrackMCMatch collection can ensure that the tracks have a sim level match. There were some bugs that were fixed in https://github.com/cms-sw/cmssw/pull/37613 However there is currently no RelVal that tests the changes in 37613

I made this customize function: https://github.com/cms-sw/cmssw/commit/473760e8249d03cc0f2e6972672af93a69d617a8

trying to add it to

runTheMatrix.py -l 10824.0  --command='--customise SimTracker/TrackAssociation/costomizeForAllTrackMCMatch.costomizeForAllTrackMCMatch'

I get this error

ValueError: Trying to override definition of trackAssociatorByHits while it is used by the sequence globalPrevalidationMuons
 new object defined in: /cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc10/cms/cmssw-patch/CMSSW_12_4_GPU_X_2022-04-19-2300/python/SimTracker/TrackAssociatorProducers/trackAssociatorByHits_cfi.py
 existing object defined in: /cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc10/cms/cmssw-patch/CMSSW_12_4_GPU_X_2022-04-19-2300/python/Validation/RecoMuon/associators_cff.py

which I understand means that the muon validation actually uses a different thing but they just called it the same: https://github.com/cms-sw/cmssw/blob/master/Validation/RecoMuon/python/associators_cff.py#L10

tvami commented 2 years ago

assign pdmv,tracking-pog

cmsbuild commented 2 years ago

New categories assigned: pdmv,tracking-pog

@bbilin,@slava77,@mmusich,@jordan-martins,@vmariani,@kskovpen you have been requested to review this Pull request/Issue and eventually sign? Thanks

cmsbuild commented 2 years ago

A new Issue was created by @tvami Tamas Vami.

@Dr15Jones, @perrotta, @dpiparo, @rappoccio, @makortel, @smuzaffar, @qliphy can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here