Phase2 duplicate pixels handling

cms-sw / cmssw

CMS Offline Software

http://cms-sw.github.io/

Apache License 2.0

1.09k stars 4.32k forks source link

Phase2 duplicate pixels handling #39007

Open jpata opened 2 years ago

jpata commented 2 years ago

In https://github.com/cms-sw/cmssw/pull/37559#issuecomment-1099529597 it was noticed that duplicate pixels are not treated correctly in the Phase2 pixel digitizer. As I understand, their appearance is currently related to the simulation code.

In the longer term (as I suggested above) - certainly longer than the target of this PR (~ urgent for Run3 consistency ), I think the digitizer logic should be changed to avoid duplicate simDigis and just sum them up upstream of any recontruction.

In the meanwhile this can become an open cmssw issue with simulation signature

jpata commented 2 years ago

assign simulation

cmsbuild commented 2 years ago

New categories assigned: simulation

@mdhildreth,@civanch you have been requested to review this Pull request/Issue and eventually sign? Thanks

cmsbuild commented 2 years ago

A new Issue was created by @jpata Joosep Pata.

@Dr15Jones, @perrotta, @dpiparo, @rappoccio, @makortel, @smuzaffar, @qliphy can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

mmusich commented 2 years ago

assign trk-dpg

mmusich commented 2 years ago

@emiglior @suchandradutta FYI

cmsbuild commented 2 years ago

New categories assigned: trk-dpg

@connorpa,@mmusich,@tsusa you have been requested to review this Pull request/Issue and eventually sign? Thanks

mmusich commented 2 years ago

urgent

apparently PR https://github.com/cms-sw/cmssw/pull/37559 has created a serious deterioration of the phase-2 track reconstruction (see https://cms-talk.web.cern.ch/t/new-validation-campaign-12-5-0-pre5-phase2-d88-added/14722/15)

srimanob commented 2 years ago

FYI @cms-sw/l1-l2 How do you use RECO track in L1T campaign? Could you please see the report above on degradation of tracks?

srimanob commented 2 years ago

Hi @mmusich

Thanks for pinging me. Should I assume the issue of tracks will propagate to objects, like electron, muon, jet right? Maybe we need to see how the issue will effect globally also.