cms-sw / cmssw

CMS Offline Software
http://cms-sw.github.io/
Apache License 2.0
1.09k stars 4.32k forks source link

Parton shower weights in P8.306 different with respect to P8.240 #39692

Open agrohsje opened 2 years ago

agrohsje commented 2 years ago

It seems we are still having a bug in the parton shower weights of P8.3. You can see the comparison for isr down between P8.240 and the P8.306 here: image I checked standalone with a few events, and already there the trend seems to be confirmed. For FSR however, I couldn't spot at difference. FSR seems to agree reasonably well. @smrenna @SanghyunKo @SiewYan @Saptaparna @menglu21

cmsbuild commented 2 years ago

A new Issue was created by @agrohsje .

@Dr15Jones, @perrotta, @dpiparo, @rappoccio, @makortel, @smuzaffar can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

agrohsje commented 2 years ago

assign generator

makortel commented 2 years ago

assign generators

cmsbuild commented 2 years ago

New categories assigned: generators

@mkirsano,@menglu21,@alberto-sanchez,@SiewYan,@GurpreetSinghChahal,@Saptaparna you have been requested to review this Pull request/Issue and eventually sign? Thanks

Saptaparna commented 2 years ago

Also opened a pythia issue: https://gitlab.com/Pythia8/releases/-/issues/214

agrohsje commented 2 years ago

The last one I can find is 211 : https://gitlab.com/Pythia8/releases/-/issues/?sort=created_date&state=all&first_page_size=20 Is it hidden ?

agrohsje commented 2 years ago

Hi @makortel. I played around with the "assign generators" command (last version above has no s, but the first one had) but the bot didn't react. As a regular user, one cannot give commands to the bot at all?

makortel commented 2 years ago

As a regular user, one cannot give commands to the bot at all?

Correct, the set of users whose commands the bot accepts is restricted to O&C L1s, release managers, L2s, and specific users listed in https://github.com/cms-sw/cms-bot/blob/master/categories.py

Saptaparna commented 2 years ago

assign generators

Saptaparna commented 2 years ago

I can't self assign either.

makortel commented 2 years ago

The issue was already assigned to generators.

agrohsje commented 2 years ago

It is already generators assigned. Matti did it. I was just wondering which commands I can issue. I assumed I just lost the right to sign but the bot doesn't listen to me at all. :-D