cms-sw / cmssw

CMS Offline Software
http://cms-sw.github.io/
Apache License 2.0
1.08k stars 4.32k forks source link

Naming of SingleParticle gen config #40044

Open srimanob opened 2 years ago

srimanob commented 2 years ago

Just accidentally see that we have improper naming of several gun samples when AddAntiParticle = cms.bool(True) is used. The name should be DoubleParticle not SingleParticle as the gen products include 2 particles. This follows the discussion in https://github.com/cms-sw/cmssw/pull/33499#issuecomment-829950866.

For example, https://github.com/cms-sw/cmssw/blob/master/Configuration/Generator/python/SinglePiPt10_pythia8_cfi.py

This file use the same structure, but use Double instead of Single: https://github.com/cms-sw/cmssw/blob/master/Configuration/Generator/python/DoubleElectronFlatPt1p5To8_cfi.py

It seems there are two ways to make config follows the name convention:

cmsbuild commented 2 years ago

A new Issue was created by @srimanob Phat Srimanobhas.

@Dr15Jones, @perrotta, @dpiparo, @rappoccio, @makortel, @smuzaffar can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

makortel commented 2 years ago

assign generators

cmsbuild commented 2 years ago

New categories assigned: generators

@mkirsano,@menglu21,@alberto-sanchez,@SiewYan,@GurpreetSinghChahal,@Saptaparna you have been requested to review this Pull request/Issue and eventually sign? Thanks

Saptaparna commented 2 years ago

please test

makortel commented 2 years ago

Umm, there is nothing to test in an issue.

Saptaparna commented 2 years ago

oops, sorry, I am approving too many PRs and accidentally requested a test.