Use TensorFlow `const` session

[clacaputo]

With PR #40161, TensorFlow interface can accept const session. Additional PRs will be made to move sessions to global cache, remove obsolete const_cast

Move sessions to global cache

• [x] L1Trigger/Phase2L1ParticleFlow/src/TauNNId.cc
• [x] RecoMET/METPUSubtraction/plugins/DeepMETProducer.cc
• [x] ~RecoTauTag/HLTProducers/src/L2TauTagNNProducer.cc~
• [x] ~RecoTauTag/RecoTau/plugins/DeepTauId.cc~
• [x] RecoTracker/TkSeedGenerator/plugins/DeepCoreSeedGenerator.cc

Remove now obsolete const_cast's

• [x] RecoHGCal/TICL/plugins/PatternRecognitionbyCA.cc
• [x] RecoHGCal/TICL/plugins/PatternRecognitionbyCLUE3D.cc
• [x] RecoHGCal/TICL/plugins/PatternRecognitionbyFastJet.cc
• [x] RecoHGCal/TICL/plugins/TrackstersMergeProducer.cc
• [x] RecoHGCal/TICL/plugins/TrackstersMergeProducerV3.cc
• [x] RecoTracker/FinalTrackSelectors/plugins/TrackTfClassifier.cc
• [x] RecoTracker/MkFit/plugins/MkFitOutputConverter.cc

Use const session

• [ ] DQM/DTMonitorClient/src/DTOccupancyTestML.cc
• [ ] L1Trigger/L1THGCal/src/concentrator/HGCalConcentratorAutoEncoderImpl.cc
• [ ] L1Trigger/L1TMuonEndCap/src/PtAssignmentEngineDxy.cc
• [ ] PhysicsTools/PatAlgos/interface/BaseMVAValueMapProducer.h
• [ ] RecoEcal/EgammaCoreTools/src/DeepSCGraphEvaluation.cc
• [ ] RecoMuon/TrackerSeedGenerator/plugins/TSGForOIDNN.cc

About the third list, it is something that can be done only in needed. @cms-sw/dqm-l2 @cms-sw/l1-l2 @cms-sw/ecal-dpg-l2 @cms-sw/muon-pog-l2 could you please comment?

FYI @riga

[clacaputo]

assign reconstruction

[cmsbuild]

New categories assigned: reconstruction

@mandrenguyen,@clacaputo you have been requested to review this Pull request/Issue and eventually sign? Thanks

[cmsbuild]

A new Issue was created by @clacaputo Claudio Caputo.

@Dr15Jones, @perrotta, @dpiparo, @rappoccio, @makortel, @smuzaffar can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

[riga]

@clacaputo

Would you agree to the following strategy?

For the now obsolete const_cast's, I would open two PRs: one for RecoHGCal and one for RecoTracker. Both of them should be fairly trivial.

The changes related to moving sessions to global caches are slightly more involved. I would first open the PR for RecoMET to see if the PR tests and review run smoothly, and if so, open the remaining PRs to L1Trigger, RecoTauTag and RecoTracker in parallel.

[clacaputo]

@riga

The strategy you proposed make sense. Thanks

[riga]

@clacaputo Feel free to check all items in the first two lists :) (after deeper inspection, there was nothing to do in RecoTauTag)