Deleting or migrating configuration files using the deprecated JetCorrector class

[wddgit]

Below is a list of configuration files that still use the deprecated JetCorrector cff configuration files. We've already migrated all the C++ code and configuration files used in existing tests (RelVals, IBs, unit tests, PR tests). The ones listed below were found using "git grep --cached filename_cff" with the filenames of central configuration cff files recently deleted.

Probably most (maybe all) of these are obsolete files that can be deleted instead of migrated. Although it is possible some are important and run by configurations not tested.

Much of this migration was done long ago by many people (Volker Adler did a lot of it). Recently, the core group centrally completed parts of the migration so that we could complete the consumes migration for ESProducers. We are leaving the rest of this to groups that maintain these files. Most of this is low priority cleanup and just deletion of files. As far as I know, these are not used and will not cause any problems other than occupying disk space and cluttering directories with junk.

Note that if there are important files that need migrating to the new JetCorrector and you need help with that, please contact me and if I have time I'll help with the JetCorrector migration itself (although I'd expect someone else to do the testing and any other needed work).

Configuration/Skimming/python/PDWG_LeptonSkim_cff.py:from JetMETCorrections.Configuration.DefaultJEC_cff import *
DQM/Physics/test/PFJet_topDQM_production_cfg.py:process.load("JetMETCorrections.Configuration.DefaultJEC_cff")
JetMETCorrections/Modules/test/FactorizedJetCorrectorDemoLocal_cfg.py:process.load('JetMETCorrections.Configuration.DefaultJEC_cff')
JetMETCorrections/Modules/test/JetCorrectorDemoLocal_cfg.py:process.load('JetMETCorrections.Configuration.DefaultJEC_cff')
JetMETCorrections/Modules/test/JetCorrectorDemoPrep_cfg.py:process.load('JetMETCorrections.Configuration.DefaultJEC_cff')
JetMETCorrections/Modules/test/testJEC_cfg.py:process.load('JetMETCorrections.Configuration.DefaultJEC_cff')
PhysicsTools/TagAndProbe/test/Electron_TagProbeTreeProducer_cfg.py:## process.load("JetMETCorrections.Configuration.DefaultJEC_cff")
RecoJets/JetAnalyzers/test/JetCorrectionUncertaintyExample.py:process.load('JetMETCorrections.Configuration.DefaultJEC_cff')
RecoJets/JetAnalyzers/test/runCMSDAS11DijetAnalyzer.py:process.load("JetMETCorrections.Configuration.DefaultJEC_cff")
RecoJets/JetAnalyzers/test/runL2L3JetCorrectionExample_cfg.py:process.load("JetMETCorrections.Configuration.DefaultJEC_cff")
RecoMET/METFilters/test/filters_cfg.py:process.load('JetMETCorrections.Configuration.DefaultJEC_cff')
RecoMET/METPUSubtraction/python/mitigatedMETSequence_cff.py:from JetMETCorrections.Configuration.DefaultJEC_cff import *
RecoMET/METPUSubtraction/python/mvaPFMET_Data_cff.py:from JetMETCorrections.Configuration.DefaultJEC_cff                     import *
RecoMET/METPUSubtraction/python/mvaPFMET_leptons_cff.py:from JetMETCorrections.Configuration.DefaultJEC_cff                     import *
RecoMET/METPUSubtraction/python/mvaPFMET_leptons_data_cff.py:from JetMETCorrections.Configuration.DefaultJEC_cff                     import *
RecoMET/METPUSubtraction/test/mvaMETOnMiniAOD_cfg.py:from JetMETCorrections.Configuration.DefaultJEC_cff import ak4PFJetsL1FastL2L3

L1Trigger/L1TNtuples/test/test_JetRecoProducer.py:#from JetMETCorrections.Configuration.JetCorrectionProducers_cff import ak4PFCHSJetsL2
RecoMET/METPUSubtraction/test/testMVAMetProducer.py:process.load('JetMETCorrections.Configuration.JetCorrectionProducers_cff')

CommonTools/RecoUtils/test/pfnopu_jets_cfg.py:process.load("JetMETCorrections.Configuration.JetCorrectionServicesAllAlgos_cff")
DQM/Physics/test/PFJet_topDQM_production_cfg.py:process.load("JetMETCorrections.Configuration.JetCorrectionServicesAllAlgos_cff")
DQM/Physics/test/topDQM_cfg.py:process.load('JetMETCorrections.Configuration.JetCorrectionServicesAllAlgos_cff')
DQM/Physics/test/topDQM_production_PU_cfg.py:process.load("JetMETCorrections.Configuration.JetCorrectionServicesAllAlgos_cff")
DQM/Physics/test/topDQM_production_PU_cfg.py:process.load("JetMETCorrections.Configuration.JetCorrectionServicesAllAlgos_cff")
HLTriggerOffline/B2G/test/b2gHLTDQM_production_cfg.py:process.load("JetMETCorrections.Configuration.JetCorrectionServicesAllAlgos_cff")
HeavyIonsAnalysis/Configuration/python/HI_DiJetSkim_cff.py:from JetMETCorrections.Configuration.JetCorrectionServicesAllAlgos_cff import *
HeavyIonsAnalysis/Configuration/python/analysisFilters_cff.py:from JetMETCorrections.Configuration.JetCorrectionServicesAllAlgos_cff import *
JetMETCorrections/Modules/test/JetCorrectionPrepTestDBReader_cfg.py:from JetMETCorrections.Configuration.JetCorrectionServicesAllAlgos_cff import *
JetMETCorrections/Modules/test/JetCorrectionProdTestDBReader_cfg.py:from JetMETCorrections.Configuration.JetCorrectionServicesAllAlgos_cff import *
PhysicsTools/PatAlgos/python/recoLayer0/metCorrections_cff.py:#from JetMETCorrections.Configuration.JetCorrectionServicesAllAlgos_cff import *
RecoMET/METPUSubtraction/python/mitigatedMETSequence_cff.py:from JetMETCorrections.Configuration.JetCorrectionServicesAllAlgos_cff import *
RecoMET/METPUSubtraction/python/mvaPFMET_Data_cff.py:from JetMETCorrections.Configuration.JetCorrectionServicesAllAlgos_cff  import *
RecoMET/METPUSubtraction/python/mvaPFMET_leptons_cff.py:from JetMETCorrections.Configuration.JetCorrectionServicesAllAlgos_cff  import *
RecoMET/METPUSubtraction/python/mvaPFMET_leptons_data_cff.py:from JetMETCorrections.Configuration.JetCorrectionServicesAllAlgos_cff  import *
Validation/RecoJets/python/JetValidation_cff.py:#from JetMETCorrections.Configuration.JetCorrectionServicesAllAlgos_cff import ak7CaloL2L3,ak7CaloL2Relative,ak7CaloL3Absolute

CommonTools/RecoUtils/test/pfnopu_jets_cfg.py:process.load("JetMETCorrections.Configuration.JetCorrectionServices_cff")
RecoMET/METPUSubtraction/python/mitigatedMETSequence_cff.py:from JetMETCorrections.Configuration.JetCorrectionServices_cff import *
RecoMET/METPUSubtraction/python/mvaPFMET_cff.py:from JetMETCorrections.Configuration.JetCorrectionServices_cff import ak4PFL1Fastjet
RecoMET/METPUSubtraction/python/pfNoPUMET_cff.py:from JetMETCorrections.Configuration.JetCorrectionServices_cff import *
RecoMET/METPUSubtraction/python/pfNoPUchsMET_cff.py:from JetMETCorrections.Configuration.JetCorrectionServices_cff import *
Validation/RecoJets/python/JetCorrectionServices_AK4CHS_cff.py:from JetMETCorrections.Configuration.JetCorrectionServices_cff import ak4PFCHSL1Offset, ak4PFCHSL1Fastjet, ak4PFCHSL2Relative, ak4PFCHSL3Absolute, ak4PFCHSResidual, ak4PFCHSL2L3, ak4PFCHSL2L3Residual
Validation/RecoJets/python/JetValidation_cff.py:#from JetMETCorrections.Configuration.JetCorrectionServices_cff import ak4JPTL1FastL2L3,ak4JPTL1Fastjet,ak4JPTL2Relative,ak4JPTL3Absolute

[cmsbuild]

A new Issue was created by @wddgit W. David Dagenhart.

@Dr15Jones, @perrotta, @dpiparo, @rappoccio, @makortel, @smuzaffar can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

[makortel]

assign pdmv,dqm,reconstruction,analysis,l1,xpog

[cmsbuild]

New categories assigned: pdmv,reconstruction,analysis,xpog,l1,dqm

@jfernan2,@bbilin,@epalencia,@ahmad3213,@micsucmed,@rvenditti,@mandrenguyen,@emanueleusai,@syuvivida,@swertz,@clacaputo,@sunilUIET,@rekovic,@kskovpen,@cecilecaillol,@vlimant,@pmandrik you have been requested to review this Pull request/Issue and eventually sign? Thanks

[vlimant]

I would suggest a central

• remove the lines with the import commented
• remove the file itself from repo

that has a better chance at getting to completion than this GH issue

[vlimant]

unassign xpog

the only file that might be relevant to xpog has the import commented out

[wddgit]

Following the suggestion from @vlimant, I deleted the lines where the import was already commented out (#40348).

For the rest of them, most of the work is in the decision whether to delete the file or not. Deleting a file is trivial. It does not make a lot of sense to do that centrally.

I also already took care of HeavyIonsAnalysis/Configuration/python/HI_DiJetSkim_cff.py.

[cecilecaillol]

unassign l1

the only file that might be relevant to l1 has the import commented out

[srimanob]

@wddgit @cms-sw/reconstruction-l2 Do we still need to do something with this issue? I think we still have the deprecated config in RecoMET.

[cmsbuild]

cms-bot internal usage

[wddgit]

First thing is this is very low priority... Just cleanup of configuration files that aren't being used.

I have not looked at this since December 2022. Just repeating the grep search, I see that most of the files are still there and have not been updated or deleted, but a few seem to have been taken care of.

This is kind of out of the Core expertise. We just provided the list so the experts in this code can look and maybe it would be helpful to get rid of some unneeded junk. It is hard for the Core group to know which files contain something useful.