search

cms-sw / cmssw

CMS Offline Software
http://cms-sw.github.io/
Apache License 2.0
1.09k stars 4.32k forks source link

archaelogy: tracking code damage from automatic (or centralized manual) forward ports in 71X #41396

Open slava77 opened 1 year ago

slava77 commented 1 year ago

we were trying to track down a part of the history of changes in RecoTracker/CkfPattern/python/CkfTrackCandidates_cfi.py

specifically, a change in #2291 was merged on Fri Feb 21, 2014 and entered https://github.com/cms-sw/cmssw/releases/tag/CMSSW_7_1_0_pre3 This entered the history as commit ab1d806475d5f0dfcd10d0c7151562656d2d861e

After that, based on git log, there is another commit that merges a 70X PR #2410 in commit b0669c73932b044811e9aabb66007ae0722f99f4 from Mon Mar 24, 2014. This happened shortly after CMSSW_7_1_0_pre5 was made and does not show up in the following pre-release https://github.com/cms-sw/cmssw/releases/tag/CMSSW_7_1_0_pre6

If I'm not mistaken, the full range of differences is in https://github.com/cms-sw/cmssw/compare/17b09fec4761fff0d4f6a3a9c44f855379dbc546...da8c15786092a82f87bb33edadfb750e48599414

[later found that] the merge was done as a part of manual centralized forward ports in #3013

@mmusich @mtosi @VinInn @cerati @rovere @makortel do you recall if this was discussed at some point in the past? I'm trying to understand if there was a partial recovery or if this was forgotten.

@mmasciov

cmsbuild commented 1 year ago

A new Issue was created by @slava77 Slava Krutelyov.

@Dr15Jones, @perrotta, @dpiparo, @rappoccio, @makortel, @smuzaffar can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

makortel commented 1 year ago

assign reconstruction

cmsbuild commented 1 year ago

New categories assigned: reconstruction

@mandrenguyen,@clacaputo you have been requested to review this Pull request/Issue and eventually sign? Thanks

makortel commented 1 year ago

I have no recollection (although what you describe rings some bell, but I don't remember what exactly).

makortel commented 1 year ago

This happened shortly after CMSSW_7_1_0_pre5 was made and does not show up in the following pre-release https://github.com/cms-sw/cmssw/releases/tag/CMSSW_7_1_0_pre6

I see this was done as part of https://github.com/cms-sw/cmssw/pull/3013 (which technically is visible in the 7_1_0_pre6 release notes, but very easy to miss).

slava77 commented 1 year ago

This happened shortly after CMSSW_7_1_0_pre5 was made and does not show up in the following pre-release https://github.com/cms-sw/cmssw/releases/tag/CMSSW_7_1_0_pre6

I see this was done as part of #3013 (which technically is visible in the 7_1_0_pre6 release notes, but very easy to miss).

Indeed, I eventually found it as well.

VinInn commented 1 year ago

No recollection what so ever (i mean was 9 years ago!)