Open srimanob opened 1 year ago
A new Issue was created by @srimanob Phat Srimanobhas.
@Dr15Jones, @perrotta, @dpiparo, @rappoccio, @makortel, @smuzaffar can you please review it and eventually sign/assign? Thanks.
cms-bot commands are listed here
assign pdmv,alca
New categories assigned: pdmv,alca
@perrotta,@bbilin,@consuegs,@sunilUIET,@francescobrivio,@saumyaphor4252,@tvami you have been requested to review this Pull request/Issue and eventually sign? Thanks
Hi Phat!
As far as I know, from alca
point of view we only import MatrixInjector
in:
https://github.com/cms-AlCaDB/AlCaVal/blob/220d580ca53ed9b71d83b7cda7713357790e5817/api/utils/run_the_matrix_alca.py#L14
but from a quick look at the code I think we only use two methods:
get_wmsplit()
prepare()
So in principle it would be a +1
from us on the clean up!
Hi @srimanob
As per discussion with the pdmv software person, we are safe with the cleanup. We mainly import from Configuration.PyReleaseValidation.MatrixInjector import MatrixInjector to implement our own version
After PdmV and Alca migrates from wmcontrol to their owns injection tool, do we still need injection part of https://github.com/cms-sw/cmssw/blob/master/Configuration/PyReleaseValidation/python/MatrixInjector.py#L19-L27 https://github.com/cms-sw/cmssw/blob/master/Configuration/PyReleaseValidation/python/MatrixInjector.py#L625-L698
It does not work at the moment. If no need, we can try to clean it a bit, and keep only needed parts, i.e. dump config (private test, or to PdmV RelVals machine)
Alca and PdmV should confirm what functions are still needed. Currently, injection does not work.