cms-sw / cmssw

CMS Offline Software
http://cms-sw.github.io/
Apache License 2.0
1.08k stars 4.32k forks source link

Clean up caloParams configurations in L1Trigger/L1TCalorimeter #42668

Open perrotta opened 1 year ago

perrotta commented 1 year ago

After the merge of https://github.com/cms-sw/cmssw/pull/42469 and https://github.com/cms-sw/cmssw/pull/42632, which are needed to provide all the configuration files required by the customizations listed in L1Trigger/Configuration/python/customiseSettings.py and updated last in https://github.com/cms-sw/cmssw/pull/42245, the directory L1Trigger/L1TCalorimeter/python is now flooded by configurations which are of no usage inside CMSSW.

Those configurations are wanted instead in the private L1T calo branch, in order to save an history of all them, and retrieve what was used or tested at a given time in case of need.

They were all ported in CMSSW because the developers would like to have synchronized the code in CMSSW and the one in their private branch, which is easier to maintain and port back and forth. However, flooding CMSSW with files non needed there is something that should be better avoided.

The above PRs were merged nonetheless in master CMSSW to allow L1T continue developing in CMSSW. However, this issue is intended to remind @cms-sw/l1-l2 to finally clean up L1Trigger/L1TCalorimeter/python from the files not needed in CMSSW.

They will certainly find the most convenient solution for maintaining CMSSW clean and saving in their local branch all the configurations they want to. Here I list a few possible alternative solutions:

def L1TSettingsToCaloParams_BlaBla(process): ...


At that point, all the configurations listed below that comment line can be removed from CMSSW.

FYA @aloeliger @bundocka 
cmsbuild commented 1 year ago

A new Issue was created by @perrotta Andrea Perrotta.

@Dr15Jones, @perrotta, @dpiparo, @rappoccio, @makortel, @smuzaffar, @antoniovilela can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

perrotta commented 1 year ago

assign l1

cmsbuild commented 1 year ago

New categories assigned: l1

@epalencia,@aloeliger you have been requested to review this Pull request/Issue and eventually sign? Thanks

aloeliger commented 1 year ago

@perrotta Thanks for this. This will go onto the priority list after handling the ongoing ZDC emulator integration, phase 2 GT menu configuration, and the upcoming L1T Athens workshop.