search

cms-sw / cmssw

CMS Offline Software
http://cms-sw.github.io/
Apache License 2.0
1.07k stars 4.28k forks source link

Issues in DQM plots reported by HIN validators during 13-2-0 campaign (and beyond) #42802

Open prebello opened 12 months ago

prebello commented 12 months ago

Dear Experts,

HIN validators have reported the following recurrent issues observed in DQM Plots (also in PdmV meeting link)

For Photons: CMSSW script : link DQM plots : https://tinyurl.com/ykjgjs4h

For Jets: Some recurrent features of the DQM plots: -the jet area is always filled at zero (https://tinyurl.com/yonognb2) -subtracted energy of CS jets is always zero (https://tinyurl.com/yp6bjqv) -plots as a function of particle candidate type are always zero (https://tinyurl.com/yq4jd34m)

Maybe you want to check to improve the HIN checks in future campaigns. Thank you.

Best regards Patricia for the HIN validation team.

cmsbuild commented 12 months ago

A new Issue was created by @prebello Patricia Rebello Teles.

@Dr15Jones, @rappoccio, @smuzaffar, @makortel, @sextonkennedy, @antoniovilela can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

makortel commented 12 months ago

assign dqm,pdmv

FYI @cms-sw/egamma-pog-l2 @cms-sw/jetmet-pog-l2

cmsbuild commented 12 months ago

New categories assigned: dqm,pdmv

@tjavaid,@AdrianoDee,@micsucmed,@nothingface0,@rvenditti,@miquork,@emanueleusai,@syuvivida,@sunilUIET,@pmandrik you have been requested to review this Pull request/Issue and eventually sign? Thanks

swagata87 commented 12 months ago

HIN validators have reported the following recurrent issues observed in DQM Plots (also in PdmV meeting link)

For Photons: CMSSW script : link DQM plots : https://tinyurl.com/ykjgjs4h

That script (Validation/RecoEgamma/plugins/PhotonValidatorMiniAOD.cc) is targeted to photon validation in MC using Higgs to gamma gamma sample. https://github.com/cms-sw/cmssw/blob/a4f12bbcb405b038a0a2bca889d88eb87efe5f3e/Validation/RecoEgamma/plugins/PhotonValidatorMiniAOD.cc#L209-L210 So I guess it won't work well for heavy ion and plots inside EgammaV/PhotonValidatorMiniAO/Photons are expected to be empty in any MC sample other than Higgs to diphoton. But there are other folders in DQM for photon validation where there should be plots with entries. Of course people can include HIN-specific plots and improve HIN-specific photon validation. There is always room for improvement.