cms-sw / cmssw

CMS Offline Software
http://cms-sw.github.io/
Apache License 2.0
1.07k stars 4.28k forks source link

[13_2] Test TestDQMOfflineConfigurationGotAll fails #42831

Open iarspider opened 12 months ago

iarspider commented 12 months ago

Test TestDQMOfflineConfigurationGotAll in DQMOffline/Configuration is failing at least since CMSSW_13_2_X_2023-09-14-2300:

===== Test "TestDQMOfflineConfigurationGotAll" ====
DQM:offlineHLTSourceOnAODextra
entry file:///data/cmsbuild/jenkins_a/workspace/ib-run-qa/CMSSW_13_2_X_2023-09-14-2300/tmp/004D960A-EA4C-E811-A908-FA163ED1F481.root
Step: DQM Spec: ['offlineHLTSourceOnAODextra']
Config file cmssw_cfg.py created

---> test TestDQMOfflineConfigurationGotAll had ERRORS
TestTime:258
^^^^ End Test TestDQMOfflineConfigurationGotAll ^^^^

The test runs the following command:

cmsswSequenceInfo.py --runTheMatrix --steps DQM,VALIDATION --infile file://${LOCALTOP}/tmp/${INFILE_NAME} --limit 50 --offset 300 --threads 1

and expects it to output Analyzing 0 seqs, but the actual output is Analyzing 1 seqs

cmsbuild commented 12 months ago

A new Issue was created by @iarspider .

@Dr15Jones, @rappoccio, @smuzaffar, @makortel, @sextonkennedy, @antoniovilela can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

iarspider commented 12 months ago

assign dqm

cmsbuild commented 12 months ago

New categories assigned: dqm

@tjavaid,@micsucmed,@nothingface0,@rvenditti,@emanueleusai,@syuvivida,@pmandrik you have been requested to review this Pull request/Issue and eventually sign? Thanks

mmusich commented 11 months ago

by trial and error I found out that this issue exists in CMSSW_13_2_4 but not in CMSSW_13_2_3. Reverting locally https://github.com/cms-sw/cmssw/pull/42714 (more specifically just commit https://github.com/cms-sw/cmssw/pull/42714/commits/5e21e71cce8757cf20c043efc223689fa687824e) the failure disappears.

mmusich commented 11 months ago

with this

diff --git a/DQMOffline/Configuration/test/BuildFile.xml b/DQMOffline/Configuration/test/BuildFile.xml
index 4334126214c..3c88e75f054 100644
--- a/DQMOffline/Configuration/test/BuildFile.xml
+++ b/DQMOffline/Configuration/test/BuildFile.xml
@@ -10,6 +10,6 @@

 <!-- To make sure we actually got all sequences, the last check checks that there are no sequences beyond the last test -->
 <!-- This might need to updated when the number of distinct sequences grows, add more rows above and change the number here. -->
-<test name="TestDQMOfflineConfigurationGotAll" command="cmsswSequenceInfo.py --runTheMatrix --steps DQM,VALIDATION --infile file://${LOCALTOP}/tmp/${INFILE_NAME} --limit 50 --offset 300 --threads 1 | grep 'Analyzing 0 seqs'">
+<test name="TestDQMOfflineConfigurationGotAll" command="cmsswSequenceInfo.py --runTheMatrix --steps DQM,VALIDATION --infile file://${LOCALTOP}/tmp/${INFILE_NAME} --limit 50 --offset 301 --threads 1 | grep 'Analyzing 0 seqs'">
   <flags PRE_TEST="GetTestDQMOfflineConfigurationFile"/>
 </test>

the problem goes away. TBH I have no idea how the offset and limits are decided. @cms-sw/dqm-l2 please clarify.