Overview of implementations to consume HCalPFCuts from DB

malbouis commented 1 year ago

This issue is to keep track of all the developments towards having the HCalPFCuts consumed from the GT.

So far, we have the following:

PF software in #43025
EGM software in #43164
Add Era modifier and "withTopo" label to event record: #43305
RecHit-based rho producer to use HCalPFCuts from GT: #43176
follow-up Phase-2 adaptations to use usePFThresholdsFromDB = True by default: #43139 and #43171
Alpaka implementations to be adapted to read HCalPFCuts from DB: #43130 and #42807

Issues opened:

From HLT, on implementing fillDescriptions for the PF producers: https://github.com/cms-sw/cmssw/issues/43169
Remove CaloTowers in PF code: https://github.com/cms-sw/cmssw/issues/43264

It would be nice to identify all the needed CMSSW changes in order to consume the HcalPFCuts from the GT. Will come back to this a later stage, but please, all, feel free to add any additional information to this issue.

FYI: @cms-sw/alca-l2 , @cms-sw/hlt-l2 , @cms-sw/pf-l2 , @cms-sw/egamma-pog-l2 , @cms-sw/orp-l2 , @cms-sw/ppd-l2

cmsbuild commented 1 year ago

A new Issue was created by @malbouis Helena Malbouisson.

@sextonkennedy, @makortel, @rappoccio, @Dr15Jones, @smuzaffar, @antoniovilela can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

mmusich commented 1 year ago

type hcal, pf, egamma

mmusich commented 1 year ago

assign alca, hlt, reconstruction

cmsbuild commented 1 year ago

New categories assigned: alca,hlt,reconstruction

@Martin-Grunewald,@mmusich,@jfernan2,@mandrenguyen,@saumyaphor4252,@perrotta,@consuegs you have been requested to review this Pull request/Issue and eventually sign? Thanks

perrotta commented 1 year ago

A search made on lxr some time ago ended up exactly with the same packages already mentioned in this issue, i.e. the ones already addressed by the open PRs and the RecoLocalCalo/CaloTowers. Just in case there are other hidden dependencies in our code on those HCalPFCuts, let me tag here also all other possible relevant POGs, which are also invited to look in their own code for such possible dependencies (and provide the needed updates, if so): @cms-sw/muon-pog-l2 @cms-sw/tau-pog-l2 @cms-sw/jetmet-pog-l2

swagata87 commented 11 months ago

Alpaka implementations to be adapted to read HCalPFCuts from DB: https://github.com/cms-sw/cmssw/pull/43130 and https://github.com/cms-sw/cmssw/pull/42807

Done in https://github.com/cms-sw/cmssw/pull/43574 (thanks @jsamudio)

mmusich commented 9 months ago

@RSalvatico pointed me to an issue in #43164, see https://github.com/cms-sw/cmssw/pull/43164#discussion_r1471740442

cms-sw / cmssw

Overview of implementations to consume HCalPFCuts from DB #43312