search

cms-sw / cmssw

CMS Offline Software
http://cms-sw.github.io/
Apache License 2.0
1.08k stars 4.3k forks source link

[DEVEL_X] Implicitly-declared 'edm::View<int>::View(const edm::View<int>&)' is deprecated #43314

Closed iarspider closed 11 months ago

iarspider commented 11 months ago

Build log: link.

iarspider commented 11 months ago

Assign DataFormats/Common

cmsbuild commented 11 months ago

New categories assigned: core

@Dr15Jones,@makortel,@smuzaffar you have been requested to review this Pull request/Issue and eventually sign? Thanks

cmsbuild commented 11 months ago

A new Issue was created by @iarspider .

@antoniovilela, @makortel, @Dr15Jones, @smuzaffar, @rappoccio, @sextonkennedy can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

iarspider commented 11 months ago

I have tried fixing this myself, but got link errors and gave up.

iarspider commented 11 months ago

@fwyzard

makortel commented 11 months ago

Copying the error message (as the log will disappear at some point)

>> Compiling  /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/225a463d1231a8a4c99dd9e7e0b20bde/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_0_DEVEL_X_2023-11-15-2300/src/DataFormats/Common/test/testRunner.cpp
CMSSW_CPU_TYPE= /data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/bin/c++ -c -DGNU_GCC -D_GNU_SOURCE -DTBB_USE_GLIBCXX_VERSION=120301 -DTBB_SUPPRESS_DEPRECATED_MESSAGES -DTBB_PREVIEW_RESUMABLE_TASKS=1 -DTBB_PREVIEW_TASK_GROUP_EXTENSIONS=1 -DBOOST_SPIRIT_THREADSAFE -DPHOENIX_THREADSAFE -DBOOST_MATH_DISABLE_STD_FPCLASSIFY -DBOOST_UUID_RANDOM_PROVIDER_FORCE_POSIX -DCMSSW_GIT_HASH='CMSSW_14_0_DEVEL_X_2023-11-15-2300' -DPROJECT_NAME='CMSSW' -DPROJECT_VERSION='CMSSW_14_0_DEVEL_X_2023-11-15-2300' -I/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/225a463d1231a8a4c99dd9e7e0b20bde/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_0_DEVEL_X_2023-11-15-2300/src -I/data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc12/external/pcre/8.43-37eb2e8b73bab83d6645ecfd5d73dcaa/include -isystem/data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc12/external/boost/1.80.0-826a207b8543c52970cb1f72d50f068c/include -I/data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc12/external/bz2lib/1.0.6-d065ccd79984efc6d4660f410e4c81de/include -I/data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc12/external/cppunit/1.15.x-fb84a4bbf5a436317d208e3ef0864e91/include -I/data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc12/external/libuuid/2.34-27ce4c3579b5b1de2808ea9c4cd8ed29/include -isystem/data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc12/lcg/root/6.26.11-1ef575234f3b954353280f3578660947/include -isystem/data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc12/external/tbb/v2021.9.0-e755918dac6a30ec36eff63ac4f7ddec/include -I/data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc12/external/xz/5.2.5-6f3f49b07db84e10c9be594a1176c114/include -I/data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc12/external/zlib/1.2.11-51072030b7f93c3ac6c4235f21e413cb/include -I/data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc12/external/fmt/8.0.1-54e94b39f5cf29341bb9c4765764e1ca/include -I/data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc12/external/md5/1.0.0-5b594b264e04ae51e893b1d69a797ec6/include -I/data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc12/external/tinyxml2/6.2.0-d17873b4d6a42a43226cf689f82ec1ef/include -O2 -pthread -pipe -Werror=main -Werror=pointer-arith -Werror=overlength-strings -Wno-vla -Werror=overflow -std=c++17 -ftree-vectorize -Werror=array-bounds -Werror=format-contains-nul -Werror=type-limits -fvisibility-inlines-hidden -fno-math-errno --param vect-max-version-for-alias-checks=50 -Xassembler --compress-debug-sections -Wno-error=array-bounds -Warray-bounds -fuse-ld=bfd -msse3 -felide-constructors -fmessage-length=0 -Wall -Wno-non-template-friend -Wno-long-long -Wreturn-type -Wextra -Wpessimizing-move -Wclass-memaccess -Wno-cast-function-type -Wno-unused-but-set-parameter -Wno-ignored-qualifiers -Wno-unused-parameter -Wunused -Wparentheses -Werror=return-type -Werror=missing-braces -Werror=unused-value -Werror=unused-label -Werror=address -Werror=format -Werror=sign-compare -Werror=write-strings -Werror=delete-non-virtual-dtor -Werror=strict-aliasing -Werror=narrowing -Werror=unused-but-set-variable -Werror=reorder -Werror=unused-variable -Werror=conversion-null -Werror=return-local-addr -Wnon-virtual-dtor -Werror=switch -fdiagnostics-show-option -Wno-unused-local-typedefs -Wno-attributes -Wno-psabi -Wno-error=unused-variable -DBOOST_DISABLE_ASSERTS -flto -fipa-icf -flto-odr-type-merging -fno-fat-lto-objects -Wodr  -fPIC  -MMD -MF tmp/el8_amd64_gcc12/src/DataFormats/Common/test/testDataFormatsCommon/testRunner.cpp.d /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/225a463d1231a8a4c99dd9e7e0b20bde/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_0_DEVEL_X_2023-11-15-2300/src/DataFormats/Common/test/testRunner.cpp -o tmp/el8_amd64_gcc12/src/DataFormats/Common/test/testDataFormatsCommon/testRunner.cpp.o
In file included from /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/225a463d1231a8a4c99dd9e7e0b20bde/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_0_DEVEL_X_2023-11-15-2300/src/DataFormats/Common/interface/RefToBaseProd.h:18,
                 from /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/225a463d1231a8a4c99dd9e7e0b20bde/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_0_DEVEL_X_2023-11-15-2300/src/DataFormats/Common/test/ref_t.cppunit.cc:16:
/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/225a463d1231a8a4c99dd9e7e0b20bde/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_0_DEVEL_X_2023-11-15-2300/src/DataFormats/Common/interface/View.h: In instantiation of 'std::unique_ptr<edm::ViewBase> edm::View<T>::doClone() const [with T = {anonymous}::IntValue]':
/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/225a463d1231a8a4c99dd9e7e0b20bde/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_0_DEVEL_X_2023-11-15-2300/src/DataFormats/Common/interface/View.h:293:29:   required from here
  /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/225a463d1231a8a4c99dd9e7e0b20bde/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_0_DEVEL_X_2023-11-15-2300/src/DataFormats/Common/interface/View.h:294:38: warning: implicitly-declared 'edm::View<{anonymous}::IntValue>::View(const edm::View<{anonymous}::IntValue>&)' is deprecated [-Wdeprecated-copy]
   294 |     return std::unique_ptr<ViewBase>{new View(*this)};
      |                                      ^~~~~~~~~~~~~~~
/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/225a463d1231a8a4c99dd9e7e0b20bde/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_0_DEVEL_X_2023-11-15-2300/src/DataFormats/Common/interface/View.h:298:19: note: because 'edm::View<{anonymous}::IntValue>' has user-provided 'edm::View<T>& edm::View<T>::operator=(const edm::View<T>&) [with T = {anonymous}::IntValue]'
  298 |   inline View<T>& View<T>::operator=(View<T> const& rhs) {
      |                   ^~~~~~~
In file included from /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/225a463d1231a8a4c99dd9e7e0b20bde/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_0_DEVEL_X_2023-11-15-2300/src/DataFormats/Common/test/reftobaseprod_t.cppunit.cc:14:
/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/225a463d1231a8a4c99dd9e7e0b20bde/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_0_DEVEL_X_2023-11-15-2300/src/DataFormats/Common/interface/RefToBaseProd.h: In instantiation of 'edm::RefToBaseProd<T>::RefToBaseProd(const edm::RefToBaseProd<T>&) [with T = {anonymous}::Dummy]':
/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/225a463d1231a8a4c99dd9e7e0b20bde/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_0_DEVEL_X_2023-11-15-2300/src/DataFormats/Common/test/reftobaseprod_t.cppunit.cc:169:44:   required from here
  /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/225a463d1231a8a4c99dd9e7e0b20bde/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_0_DEVEL_X_2023-11-15-2300/src/DataFormats/Common/interface/RefToBaseProd.h:111:47: warning: implicitly-declared 'edm::View<{anonymous}::Dummy>::View(const edm::View<{anonymous}::Dummy>&)' is deprecated [-Wdeprecated-copy]
   111 |       product_.setProductPtr(ref.viewPtr() ? (new View<T>(*ref)) : nullptr);
      |                                              ~^~~~~~~~~~~~~~~~~~
In file included from /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/225a463d1231a8a4c99dd9e7e0b20bde/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_0_DEVEL_X_2023-11-15-2300/src/DataFormats/Common/interface/RefToBaseProd.h:18:
/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/225a463d1231a8a4c99dd9e7e0b20bde/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_0_DEVEL_X_2023-11-15-2300/src/DataFormats/Common/interface/View.h:298:19: note: because 'edm::View<{anonymous}::Dummy>' has user-provided 'edm::View<T>& edm::View<T>::operator=(const edm::View<T>&) [with T = {anonymous}::Dummy]'
  298 |   inline View<T>& View<T>::operator=(View<T> const& rhs) {
      |                   ^~~~~~~
/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/225a463d1231a8a4c99dd9e7e0b20bde/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_0_DEVEL_X_2023-11-15-2300/src/DataFormats/Common/interface/RefToBaseProd.h: In instantiation of 'edm::RefToBaseProd<T>::RefToBaseProd(const edm::RefToBaseProd<T>&) [with T = test_with_dictionaries::IntValue]':
/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/225a463d1231a8a4c99dd9e7e0b20bde/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_0_DEVEL_X_2023-11-15-2300/src/DataFormats/Common/test/reftobaseprod_t.cppunit.cc:231:42:   required from here
  /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/225a463d1231a8a4c99dd9e7e0b20bde/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_0_DEVEL_X_2023-11-15-2300/src/DataFormats/Common/interface/RefToBaseProd.h:111:47: warning: implicitly-declared 'edm::View<test_with_dictionaries::IntValue>::View(const edm::View<test_with_dictionaries::IntValue>&)' is deprecated [-Wdeprecated-copy]
   111 |       product_.setProductPtr(ref.viewPtr() ? (new View<T>(*ref)) : nullptr);
      |                                              ~^~~~~~~~~~~~~~~~~~
/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/225a463d1231a8a4c99dd9e7e0b20bde/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_0_DEVEL_X_2023-11-15-2300/src/DataFormats/Common/interface/View.h:298:19: note: because 'edm::View<test_with_dictionaries::IntValue>' has user-provided 'edm::View<T>& edm::View<T>::operator=(const edm::View<T>&) [with T = test_with_dictionaries::IntValue]'
  298 |   inline View<T>& View<T>::operator=(View<T> const& rhs) {
      |                   ^~~~~~~
/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/225a463d1231a8a4c99dd9e7e0b20bde/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_0_DEVEL_X_2023-11-15-2300/src/DataFormats/Common/interface/View.h: In instantiation of 'std::unique_ptr<edm::ViewBase> edm::View<T>::doClone() const [with T = {anonymous}::Dummy]':
/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/225a463d1231a8a4c99dd9e7e0b20bde/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_0_DEVEL_X_2023-11-15-2300/src/DataFormats/Common/interface/View.h:293:29:   required from here
  /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/225a463d1231a8a4c99dd9e7e0b20bde/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_0_DEVEL_X_2023-11-15-2300/src/DataFormats/Common/interface/View.h:294:38: warning: implicitly-declared 'edm::View<{anonymous}::Dummy>::View(const edm::View<{anonymous}::Dummy>&)' is deprecated [-Wdeprecated-copy]
   294 |     return std::unique_ptr<ViewBase>{new View(*this)};
      |                                      ^~~~~~~~~~~~~~~
/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/225a463d1231a8a4c99dd9e7e0b20bde/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_0_DEVEL_X_2023-11-15-2300/src/DataFormats/Common/interface/View.h:298:19: note: because 'edm::View<{anonymous}::Dummy>' has user-provided 'edm::View<T>& edm::View<T>::operator=(const edm::View<T>&) [with T = {anonymous}::Dummy]'
  298 |   inline View<T>& View<T>::operator=(View<T> const& rhs) {
      |                   ^~~~~~~
/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/225a463d1231a8a4c99dd9e7e0b20bde/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_0_DEVEL_X_2023-11-15-2300/src/DataFormats/Common/interface/View.h: In instantiation of 'std::unique_ptr<edm::ViewBase> edm::View<T>::doClone() const [with T = test_with_dictionaries::IntValue]':
/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/225a463d1231a8a4c99dd9e7e0b20bde/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_0_DEVEL_X_2023-11-15-2300/src/DataFormats/Common/interface/View.h:293:29:   required from here
  /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/225a463d1231a8a4c99dd9e7e0b20bde/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_0_DEVEL_X_2023-11-15-2300/src/DataFormats/Common/interface/View.h:294:38: warning: implicitly-declared 'edm::View<test_with_dictionaries::IntValue>::View(const edm::View<test_with_dictionaries::IntValue>&)' is deprecated [-Wdeprecated-copy]
   294 |     return std::unique_ptr<ViewBase>{new View(*this)};
      |                                      ^~~~~~~~~~~~~~~
/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/225a463d1231a8a4c99dd9e7e0b20bde/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_0_DEVEL_X_2023-11-15-2300/src/DataFormats/Common/interface/View.h:298:19: note: because 'edm::View<test_with_dictionaries::IntValue>' has user-provided 'edm::View<T>& edm::View<T>::operator=(const edm::View<T>&) [with T = test_with_dictionaries::IntValue]'
  298 |   inline View<T>& View<T>::operator=(View<T> const& rhs) {
      |                   ^~~~~~~
aandvalenzuela commented 11 months ago

Wouldn't it work by removing the assigment operator but not the distructor (since it has to be overrided)? I did an attempt at https://github.com/cms-sw/cmssw/pull/43319

aandvalenzuela commented 11 months ago

No, it does not work :(

makortel commented 11 months ago

Fixed in https://github.com/cms-sw/cmssw/pull/43337

makortel commented 11 months ago

+core

cmsbuild commented 11 months ago

This issue is fully signed and ready to be closed.