search

cms-sw / cmssw

CMS Offline Software
http://cms-sw.github.io/
Apache License 2.0
1.08k stars 4.29k forks source link

review/update PackedCandidate packedHits_ and packedLayers_ to cover phase-2 IT tracker (etc) #43474

Open slava77 opened 10 months ago

slava77 commented 10 months ago

@AlexDeMoor noted that the truncation/packing done in ParckedCandidate::setHits may in general be insufficient https://github.com/cms-sw/cmssw/blob/27bec5ff620bde58ac4a2a2812a545e881c47117/DataFormats/PatCandidates/interface/PackedCandidate.h#L623-L647

Notably, pixel layer/hits are truncated at 7, which is insufficient for phase-2 IT.

The strips are truncated at 31, which should be OK for the current SST or for OT.

@cms-sw/xpog-l2 @cms-sw/tracking-pog-l2 @cms-sw/btv-pog-l2

cmsbuild commented 10 months ago

A new Issue was created by @slava77 Slava Krutelyov.

@antoniovilela, @rappoccio, @makortel, @smuzaffar, @sextonkennedy, @Dr15Jones can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

slava77 commented 10 months ago

type tracking

mmusich commented 10 months ago

Notably, pixel layer/hits are truncated at 7, which is insufficient for phase-2 IT.

Looking at a typical phase-2 geometry in the tkLayout page (here for geometry T32, layout OT800_IT615), looks like at the peak there's about 16 Inner Tracker hits and 10 crossed layers

image image

makortel commented 10 months ago

assign DataFormats/PatCandidates

cmsbuild commented 10 months ago

New categories assigned: reconstruction,xpog

@vlimant,@simonepigazzini,@jfernan2,@mandrenguyen you have been requested to review this Pull request/Issue and eventually sign? Thanks