search

cms-sw / cmssw

CMS Offline Software
http://cms-sw.github.io/
Apache License 2.0
1.07k stars 4.28k forks source link

Inconsistency in `Summary_TotalNumberOfClusters_OffTrack*` histogram axis ranges between code and configuration #44062

Open makortel opened 6 months ago

makortel commented 6 months ago

Tests of ROOT master update in https://github.com/cms-sw/cmsdist/pull/9025#issuecomment-1955359251 revealed an inconsistency in histogram axis settings between configuration in https://github.com/cms-sw/cmssw/blob/306f63bd666e6b11a0aa75010dd10473fb4643e5/DQM/SiStripMonitorClient/python/SiStripSourceConfigTier0_Cosmic_cff.py#L70-L76 and in code in https://github.com/cms-sw/cmssw/blob/306f63bd666e6b11a0aa75010dd10473fb4643e5/DQM/SiStripMonitorTrack/src/SiStripMonitorTrack.cc#L729-L751

ROOT master issues now a warning when TAxis::SetRangeUser() (called by MonitorElement:: setAxisRange()) arguments are out of the range of the histogram.

The question is if the present behavior is the intended one, and if the present code is adequate to express the desired behavior.

makortel commented 6 months ago

assign dqm

FYI @cms-sw/trk-dpg-l2

cmsbuild commented 6 months ago

New categories assigned: dqm

@rvenditti,@syuvivida,@tjavaid,@nothingface0,@antoniovagnerini you have been requested to review this Pull request/Issue and eventually sign? Thanks

cmsbuild commented 6 months ago

cms-bot internal usage

cmsbuild commented 6 months ago

A new Issue was created by @makortel.

@smuzaffar, @sextonkennedy, @antoniovilela, @Dr15Jones, @rappoccio, @makortel can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

makortel commented 6 months ago

From core perspective we are going to work around the exception by demoting these ROOT warnings to INFO messages (in https://github.com/cms-sw/cmssw/pull/44060; if anyone thinks these warnings should be kept as exceptions please speak up), so the impact of "not doing anything" would be some number of INFO messages (that are not printed by default, even if the messages are processed, i.e. there is some cost) for every Run.