search

cms-sw / cmssw

CMS Offline Software
http://cms-sw.github.io/
Apache License 2.0
1.08k stars 4.3k forks source link

PileUp::endStream(ExceptionCollector& exceptionCollector) calling endJob #45506

Open wddgit opened 3 months ago

wddgit commented 3 months ago

Review the behavior in the function PileUp::endStream. It seems strange that this function calls endJob for modules multiple times in the same job. This was noticed during review of another PR (#45434), but it is not really directly related or in the scope of that PR. Should this behavior be modified or fixed? Is this code used anymore? Do we use PileUp to run modules anymore? Do we want to keep this capability alive for possible future use? Should we clean it up and delete all code supporting this ability?

These are low priority questions, but not easy to answer. We didn't have time to answer while reviewing that PR. Documenting them here so we can come back to this when we have time. We should at least delete the comment I added into that function...

cmsbuild commented 3 months ago

cms-bot internal usage

cmsbuild commented 3 months ago

A new Issue was created by @wddgit.

@Dr15Jones, @antoniovilela, @makortel, @mandrenguyen, @rappoccio, @sextonkennedy, @smuzaffar can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

makortel commented 3 months ago

assign core, simulation

cmsbuild commented 3 months ago

New categories assigned: core,simulation

@Dr15Jones,@civanch,@makortel,@mdhildreth,@smuzaffar you have been requested to review this Pull request/Issue and eventually sign? Thanks

makortel commented 3 months ago

Is this code used anymore? Do we use PileUp to run modules anymore?

For history I removed the last use in https://github.com/cms-sw/cmssw/pull/24184 . I think we should seriously consider to remove the functionality of running modules as part of the EmbeddedRootSource.