search

cms-sw / cmssw

CMS Offline Software
http://cms-sw.github.io/
Apache License 2.0
1.07k stars 4.28k forks source link

[L1T] Propagating updates for HTMHF object to DQM and NanoAOD #45538

Open elfontan opened 1 month ago

elfontan commented 1 month ago

This issue is to document a few leftover changes to the code from https://github.com/cms-sw/cmssw/pull/45295 , that were considered beyond the scope of that PR (see comment here). [Cc: @missirol]

New HTMHF triggers have been integrated in the GT emulator for the version 2024_v1_3_0 of the L1 menu (end of 2024 pp data-taking). This new object may need to be propagated downstream in a few places for DQM and NanoAOD, for example:

It might be worth also checking why in the NanoAOD part, e.g. here, TriggerL1ETM is being used for L1ETMHF.

[cc: @aloeliger @epalencia for L1 OSW, @eyigitba @slaurila @bundocka for Offline DQM, @artlbv for Nano]

cmsbuild commented 1 month ago

cms-bot internal usage

cmsbuild commented 1 month ago

A new Issue was created by @elfontan.

@Dr15Jones, @antoniovilela, @makortel, @mandrenguyen, @rappoccio, @sextonkennedy, @smuzaffar can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

artlbv commented 1 month ago

hi Elisa, thanks for mentioning. The part on Nano actually seems to be something more upstream as these types are defined in the HLTReco DataFormats and thus used primarily by HLT.

I see that there are indeed types for each EtSum, however as you correctly point out there is no differentiation made between the no-HF and with-HF sums in the Nano TriggerObjectTableProducer: https://github.com/cms-sw/cmssw/blob/f6e0fc429ceb8c78f0f0391bcc915e696065122d/PhysicsTools/NanoAOD/plugins/TriggerObjectTableProducer.cc#L229-L237

In this HLT plugin HLTLevel1GTSeed there are no with-HF sums at all: https://github.com/cms-sw/cmssw/blob/f6e0fc429ceb8c78f0f0391bcc915e696065122d/HLTrigger/HLTfilters/plugins/HLTLevel1GTSeed.cc#L1598-L1608

In the HLTL1TSeed plugin the type assignment seems correct: https://github.com/cms-sw/cmssw/blob/f6e0fc429ceb8c78f0f0391bcc915e696065122d/HLTrigger/HLTfilters/plugins/HLTL1TSeed.cc#L307-L325

As I do not know how and where else this is used, I would prefer that our XPOG ( @vlimant @hqucms @ftorrresd ) and HLT (@missirol @Martin-Grunewald @mmusich ) colleagues comment on this and if there are any objections on fixing the sum types in that file?

p.s. I also found a similar TriggerTypeDefs_cfi file in the HLT/EGamma package which does not seem to be up to date: https://github.com/cms-sw/cmssw/blob/master/HLTriggerOffline/Egamma/python/TriggerTypeDefs_cfi.py

mmusich commented 1 month ago

assign l1, dqm, xpog, hlt

cmsbuild commented 1 month ago

New categories assigned: l1,dqm,xpog,hlt

@Martin-Grunewald,@mmusich,@vlimant,@hqucms,@ftorrresd,@epalencia,@aloeliger,@rvenditti,@syuvivida,@tjavaid,@nothingface0,@antoniovagnerini you have been requested to review this Pull request/Issue and eventually sign? Thanks

Martin-Grunewald commented 1 month ago

HLTLevel1GTSeed is the old filter plugin (used for L1T legacy and stage-1 L1T, in the HLT Fake and Fake1 menus, correspondingly). The corresponding new filter plugin is HLTL1TSeed (stage-2 L1T). Thus of these two plugins, only the latter gets updated these days with new Run-3 developments. IOW, no action needed for plugins HLTLevel1GTSeed and HLTL1TSeed.

vlimant commented 1 month ago

It might be worth also checking why in the NanoAOD part, e.g. here, TriggerL1ETM is being used for L1ETMHF.

looks like a bug to me indeed, and I wonder how no one noticed it until now, except if that trigger object table content is useless ...