search

cms-sw / cmssw

CMS Offline Software
http://cms-sw.github.io/
Apache License 2.0
1.07k stars 4.28k forks source link

MAHI-Alpaka improvements #45651

Open kakwok opened 1 month ago

kakwok commented 1 month ago

This is a collection of topics left out of the initial migration of MAHI to Alpaka https://github.com/cms-sw/cmssw/pull/44910 Some details of these topics are included in the HCAL PSG slides.

Technical improvements:

  1. Protection against wrong number of digi sample: #44541
  2. Use EIGEN_COLUMNS, instead of n arrays.
    • For DigiSoA and MahiConditionsSoA
  3. Optimize Stride usage of DigiSoA
  4. Related to #45595, remove rechits with chi2<0 from the output rechits

Algorithmic improvements:

  1. Missing Method-0 features, containment and time slew : line
  2. Related to technical (1), extend Alpaka-MAHI to work in different digi length
  3. Non-deterministic behavior for TS with same energy: line
cmsbuild commented 1 month ago

cms-bot internal usage

cmsbuild commented 1 month ago

A new Issue was created by @kakwok.

@Dr15Jones, @antoniovilela, @makortel, @mandrenguyen, @rappoccio, @sextonkennedy, @smuzaffar can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

makortel commented 1 month ago

assign heterogeneous, reconstruction

FYI @cms-sw/hcal-dpg-l2

cmsbuild commented 1 month ago

New categories assigned: heterogeneous,reconstruction

@fwyzard,@jfernan2,@makortel,@mandrenguyen you have been requested to review this Pull request/Issue and eventually sign? Thanks

jfernan2 commented 1 week ago

FYI @abdoulline @igv4321 as HCAL reco contacts