search

cms-sw / cmssw

CMS Offline Software
http://cms-sw.github.io/
Apache License 2.0
1.07k stars 4.28k forks source link

[LLVM analyzer] Assigned value is garbage or undefined in TopQuarkAnalysis/TopKinFitter/src/TtFullLepKinSolver.cc #46021

Open iarspider opened 2 days ago

iarspider commented 2 days ago

LLVM reports that value assigned to z here is undefined.

This will happen if this branch of cubic is executed. Can we return 0 if cubic returns 0?

iarspider commented 2 days ago

assign TopQuarkAnalysis/TopKinFitter

cmsbuild commented 2 days ago

New categories assigned: analysis

@tvami you have been requested to review this Pull request/Issue and eventually sign? Thanks

cmsbuild commented 2 days ago

cms-bot internal usage

cmsbuild commented 2 days ago

A new Issue was created by @iarspider.

@Dr15Jones, @antoniovilela, @makortel, @mandrenguyen, @rappoccio, @sextonkennedy, @smuzaffar can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

tvami commented 2 days ago

I'll have a look, this seems quite easy to fix