[LLVM Analyzer] Invalid bitwise shift

cms-sw / cmssw

CMS Offline Software

http://cms-sw.github.io/

Apache License 2.0

1.09k stars 4.32k forks source link

[LLVM Analyzer] Invalid bitwise shift #46037

Open iarspider opened 2 months ago

iarspider commented 2 months ago

LLVM analyzer reports these instances of invalid bitwise shifts:

Shift by too-large value in EgammaHLTPixelMatchVarProducer.cc, HGCalVFECompressionImpl::compressSingle, hgcal::econd::produceERxData
Negative shift in HOTriggerPrimitiveDigi::HOTriggerPrimitiveDigi, Stub::Stub, TCPReceiver::ReceiveLumiSection

(the last one could be a false-positive)

cmsbuild commented 2 months ago

cms-bot internal usage

cmsbuild commented 2 months ago

A new Issue was created by @iarspider.

@Dr15Jones, @antoniovilela, @makortel, @mandrenguyen, @rappoccio, @sextonkennedy, @smuzaffar can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

iarspider commented 2 months ago

assign DataFormats/HcalDigi, L1Trigger/TrackFindingTracklet, RecoEgamma/EgammaHLTProducers, RecoLuminosity/TCPReceiver

cmsbuild commented 2 months ago

New categories assigned: simulation,l1,hlt,reconstruction

@Martin-Grunewald,@mmusich,@civanch,@jfernan2,@mandrenguyen,@mdhildreth,@epalencia,@aloeliger,@kpedro88 you have been requested to review this Pull request/Issue and eventually sign? Thanks

iarspider commented 2 months ago

assign L1Trigger/L1THGCal,EventFilter/HGCalRawToDigi

cmsbuild commented 2 months ago

New categories assigned: upgrade

@srimanob,@subirsarkar you have been requested to review this Pull request/Issue and eventually sign? Thanks

mmusich commented 2 months ago

Shift by too-large value in EgammaHLTPixelMatchVarProducer.cc,

tagging @Sam-Harper as original author of this code (via https://github.com/cms-sw/cmssw/pull/18541)

kpedro88 commented 2 months ago

HOTriggerPrimitiveDigi: @jmmans TrackFindingTracklet/Stub: @skinnari @aryd