Open makortel opened 2 weeks ago
assign Configuration/PyReleaseValidation
New categories assigned: pdmv,upgrade
@AdrianoDee,@kskovpen,@miquork,@Moanwar,@srimanob,@subirsarkar,@sunilUIET you have been requested to review this Pull request/Issue and eventually sign? Thanks
cms-bot internal usage
A new Issue was created by @makortel.
@Dr15Jones, @antoniovilela, @makortel, @mandrenguyen, @rappoccio, @sextonkennedy, @smuzaffar can you please review it and eventually sign/assign? Thanks.
cms-bot commands are listed here
I'm taking a look a this and I was thinking: this applies also to non "ProdLike" wfs, doesn't it? Unless I'm missing something, the pile-up input at RECO step is useless in any case.
Unless I'm missing something, the pile-up input at RECO step is useless in any case.
If the RECO (or any non-DIGI) step includes VALIDATION, the pileup mixing is played back, because some validation code uses data products, such as CrossingFrame<T>
, that are transient in the DIGI step (for good reasons).
https://github.com/cms-sw/cmssw/blob/6d26b89d99a92507aad02623bd3feac40f65d369/Configuration/Applications/python/ConfigBuilder.py#L1913
...
https://github.com/cms-sw/cmssw/blob/6d26b89d99a92507aad02623bd3feac40f65d369/Configuration/Applications/python/ConfigBuilder.py#L1969-L1973
Understood, thanks Matti for the clarification.
I noticed the RECO step (as well as MiniAOD (
PAT
) and NanoAOD steps) in ProdLike workflows, such as 13034.21, query and set the pileup files because of havingIn practice it seems the MixingModule doesn't get run in any of these steps as the MinBias file opens are not shown in the logs, and the module is also not shown in the summary printout (probably in absence of
VALIDATION
step themix
module doesn't get associated to theSchedule
via any path).I'd argue it would nevertheless be clearer if the
--pileup ... --pileup_input
options would be omitted in the steps that should not runMixingModule
.