search

cms-sw / cmssw

CMS Offline Software
http://cms-sw.github.io/
Apache License 2.0
1.09k stars 4.33k forks source link

RECO step in ProdLike workflows sets pileup files #46121

Open makortel opened 2 months ago

makortel commented 2 months ago

I noticed the RECO step (as well as MiniAOD (PAT) and NanoAOD steps) in ProdLike workflows, such as 13034.21, query and set the pileup files because of having

--pileup Run3_Flat55To75_PoissonOOTPU --pileup_input das:/RelValMinBias_14TeV/CMSSW_14_0_0_pre3-140X_mcRun3_2024_realistic_v1_STD_2024_noPU-v1/GEN-SIM

In practice it seems the MixingModule doesn't get run in any of these steps as the MinBias file opens are not shown in the logs, and the module is also not shown in the summary printout (probably in absence of VALIDATION step the mix module doesn't get associated to the Schedule via any path).

I'd argue it would nevertheless be clearer if the --pileup ... --pileup_input options would be omitted in the steps that should not run MixingModule.

makortel commented 2 months ago

assign Configuration/PyReleaseValidation

cmsbuild commented 2 months ago

New categories assigned: pdmv,upgrade

@AdrianoDee,@kskovpen,@miquork,@Moanwar,@srimanob,@subirsarkar,@sunilUIET you have been requested to review this Pull request/Issue and eventually sign? Thanks

cmsbuild commented 2 months ago

cms-bot internal usage

cmsbuild commented 2 months ago

A new Issue was created by @makortel.

@Dr15Jones, @antoniovilela, @makortel, @mandrenguyen, @rappoccio, @sextonkennedy, @smuzaffar can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

AdrianoDee commented 2 months ago

I'm taking a look a this and I was thinking: this applies also to non "ProdLike" wfs, doesn't it? Unless I'm missing something, the pile-up input at RECO step is useless in any case.

makortel commented 2 months ago

Unless I'm missing something, the pile-up input at RECO step is useless in any case.

If the RECO (or any non-DIGI) step includes VALIDATION, the pileup mixing is played back, because some validation code uses data products, such as CrossingFrame<T>, that are transient in the DIGI step (for good reasons). https://github.com/cms-sw/cmssw/blob/6d26b89d99a92507aad02623bd3feac40f65d369/Configuration/Applications/python/ConfigBuilder.py#L1913 ... https://github.com/cms-sw/cmssw/blob/6d26b89d99a92507aad02623bd3feac40f65d369/Configuration/Applications/python/ConfigBuilder.py#L1969-L1973

AdrianoDee commented 2 months ago

Understood, thanks Matti for the clarification.

Dr15Jones commented 1 month ago

NOTE: I ran the exact same cmsDriver.py commands for step 3 - 5 but omitted the command line options adding the pileup and the steps ran just fine.

AdrianoDee commented 1 month ago

For the ProdLike wfs I've opened https://github.com/cms-sw/cmssw/pull/46521.