Dataset branch in NanoAOD

patinkaew commented 2 months ago

I would like to start a discussion. I noticed that Dataset branch has been created since NanoAODv13 [1] and I'm not sure whether this is what we expect. I believe Dataset branch is added because introduction of ScoutingNano since only branches in Dataset are Scouting datasets (ScoutingPFRun3, ScoutingPFMonitor). They seems to be added unintentionally at, for example, [2] since Scouting paths started with DST, not L1 or HLT, e.g. DST_PFScouting_JetHT_v*.

The question: should we keep Dataset branch or drop it?

First of all, this branch is very small (two bits), so this might not matter at all.
I can think of one use case for Dataset branch. If one wants to match the same event in different dataset, Dataset branch can be useful. However, I believe Dataset flags can be created by logical-OR of relevant HLT flags which are already stored in NanoAOD.
The solution is to instead of checking that flag contains Scouting as it is currently done, we can check that the flag starts with DST and contains Scouting. Checking Scouting paths on HLT-Scouting wiki [3], I believe this condition should pick up all Scouting paths used in 2022-2024.

[1] https://cms-nanoaod-integration.web.cern.ch/autoDoc/ [2] https://github.com/cms-sw/cmssw/blob/master/PhysicsTools/NanoAOD/plugins/TriggerOutputBranches.cc#L25 [3] https://cms-hlt-scouting.docs.cern.ch/PathsRecoContent/Paths/

cmsbuild commented 2 months ago

cms-bot internal usage

cmsbuild commented 2 months ago

A new Issue was created by @patinkaew.

@Dr15Jones, @antoniovilela, @makortel, @mandrenguyen, @rappoccio, @sextonkennedy, @smuzaffar can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

makortel commented 2 months ago

assign xpog

cmsbuild commented 2 months ago

New categories assigned: xpog

@ftorrresd,@hqucms you have been requested to review this Pull request/Issue and eventually sign? Thanks

cms-sw / cmssw

Dataset branch in NanoAOD #46122