search

cms-sw / cmssw

CMS Offline Software
http://cms-sw.github.io/
Apache License 2.0
1.09k stars 4.32k forks source link

LLVM Analyzer: use-after-move #46155

Open iarspider opened 1 month ago

iarspider commented 1 month ago

LLVM Analyzer reports two instances of use-after-move:

iarspider commented 1 month ago

assign RecoEgamma/PhotonIdentification, CalibCalorimetry/EcalTPGTools

cmsbuild commented 1 month ago

New categories assigned: reconstruction,alca,l1

@aloeliger,@atpathak,@consuegs,@epalencia,@jfernan2,@mandrenguyen,@perrotta you have been requested to review this Pull request/Issue and eventually sign? Thanks

cmsbuild commented 1 month ago

cms-bot internal usage

cmsbuild commented 1 month ago

A new Issue was created by @iarspider.

@Dr15Jones, @antoniovilela, @makortel, @mandrenguyen, @rappoccio, @sextonkennedy, @smuzaffar can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

makortel commented 1 month ago

The "fix" (to silence the warning) would be to pass edm::ConsumesCollector by value instead of rvalue reference (for historical note passing it by value was not originally possible, that then lead to this pattern of rvalue references).