[LLVM][L1] Dead assignment in L1NNCaloTauEmulator::produce

cms-sw / cmssw

CMS Offline Software

http://cms-sw.github.io/

Apache License 2.0

1.07k stars 4.29k forks source link

[LLVM][L1] Dead assignment in L1NNCaloTauEmulator::produce #46265

Open iarspider opened 2 days ago

iarspider commented 2 days ago

LLVM analyzer reports dead assignment in L1NNCaloTauEmulator::produce: link

 float idScore = -1.;
 if (!VsPuId.method().empty()) {
   idScore = VsPuId.passID(*cl3dIt, cluster);
   idScore = cluster.egVsPUMVAOut();
 }

@cms-sw/l1-l2 could you please check if the return value of VsPuId.passID should be discarded or used?

iarspider commented 2 days ago

assign l1

cmsbuild commented 2 days ago

New categories assigned: l1

@aloeliger,@epalencia you have been requested to review this Pull request/Issue and eventually sign? Thanks

cmsbuild commented 2 days ago

cms-bot internal usage

cmsbuild commented 2 days ago

A new Issue was created by @iarspider.

@Dr15Jones, @antoniovilela, @makortel, @mandrenguyen, @rappoccio, @sextonkennedy, @smuzaffar can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here