[Run3 PromptReco] 117k memory allocations per event in string manipulation in `SiStripMonitorTrack::analyze()`

makortel commented 1 month ago

From https://github.com/cms-sw/cmssw/issues/46040#issuecomment-2420404065

The SiStripMonitorTrack::analyze() makes a total of 467k memory allocations per event (2.0 % of all memory allocations in the event processing, IgProf profile of 1000 events This divides into

327 k in std::vector<float>::reserve() link
117 k in SiStripMonitorTrack::findMEs() link
- All of these are std::string operations via SiStripFolderOrganizer::getSubDetFolderAndTag() and SiStripHistoId::getSubdetid()

I don't know how much could be done for the std::vector<float>s, but the string manipulations via SiStripMonitorTrack::findMEs() certainly smell.

makortel commented 1 month ago

assign dqm

makortel commented 1 month ago

type performance-improvements

cmsbuild commented 1 month ago

New categories assigned: dqm

@antoniovagnerini,@nothingface0,@rvenditti,@syuvivida,@tjavaid you have been requested to review this Pull request/Issue and eventually sign? Thanks

cmsbuild commented 1 month ago

cms-bot internal usage

cmsbuild commented 1 month ago

A new Issue was created by @makortel.

@Dr15Jones, @antoniovilela, @makortel, @mandrenguyen, @rappoccio, @sextonkennedy, @smuzaffar can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

cms-sw / cmssw

[Run3 PromptReco] 117k memory allocations per event in string manipulation in `SiStripMonitorTrack::analyze()` #46498