Open makortel opened 1 hour ago
assign Geometry/MTDNumberingBuilder
New categories assigned: geometry,upgrade
@bsunanda,@civanch,@Dr15Jones,@kpedro88,@makortel,@mdhildreth,@Moanwar,@srimanob,@subirsarkar you have been requested to review this Pull request/Issue and eventually sign? Thanks
cms-bot internal usage
A new Issue was created by @makortel.
@Dr15Jones, @antoniovilela, @makortel, @mandrenguyen, @rappoccio, @sextonkennedy, @smuzaffar can you please review it and eventually sign/assign? Thanks.
cms-bot commands are listed here
@cms-sw/mtd-dpg-l2
From https://github.com/cms-sw/cmssw/issues/45854#issuecomment-2436137581
The
MTDGeometricTimingDetESModule::produce()
makes ~12 million memory allocations, of which nearly all come from string construction inDDNameFilter::accept()
(IgProf profile) https://github.com/cms-sw/cmssw/blob/f71ff4c3c27738ed0f20b3852adb60083a1e81a1/Geometry/MTDNumberingBuilder/plugins/DDCmsMTDConstruction.cc#L28-L29The
ev.logicalPart().name().fullname()
returns a newly constructedstring
https://github.com/cms-sw/cmssw/blob/f71ff4c3c27738ed0f20b3852adb60083a1e81a1/DetectorDescription/Core/interface/DDName.h#L40-L43Especially how the
DDNameFilter
is used https://github.com/cms-sw/cmssw/blob/f71ff4c3c27738ed0f20b3852adb60083a1e81a1/Geometry/MTDNumberingBuilder/plugins/DDCmsMTDConstruction.cc#L48-L51 I'd suggest to compare the namespace and name parts ofDDName
separately to avoid the string construction.