[14_1_X] Backport of modifications to make ZDC trigger spacing configurable with TP channel parameters.

hjbossi commented 2 days ago

PR description:

This PR takes a parameter hard-coded in the HCAL LUT generation for the ZDC and replaces it with a second auxiliary parameter from the HCAL TP Channel Parameters conditions. This is in order to change the granularity of the ZDC trigger decision (currently set to 1 count = 50 GeV) in coordination with ZDC gain changes set forth by changing the operating voltage. Whenever the conditions are updated to modify this parameter, this will also require a modification of the L1 menu. Therefore this PR will need to be carefully synchronized for deployment.

PR validation:

This PR was tested locally on 2024 HI data taken with spurious collisions over the weekend.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This PR is a backport of https://github.com/cms-sw/cmssw/pull/46537 and is meant for CMSSW_14_1_X and is intended for HI data-taking.

cmsbuild commented 2 days ago

A new Pull Request was created by @hjbossi for CMSSW_14_1_X.

It involves the following packages:

CalibCalorimetry/HcalTPGAlgos (l1, alca)

@aloeliger, @atpathak, @cmsbuild, @consuegs, @epalencia, @perrotta can you please review it and eventually sign? Thanks. @abdoulline, @bsunanda, @mmusich, @rsreds, @tocheng, @yuanchao this is something you requested to watch as well. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

cmsbuild commented 2 days ago

cms-bot internal usage

abdoulline commented 1 day ago

I'd suggest to add a "prefix" to the title: [14_1_X], this is a standard practice to emphasize the importance and to make the PR visible in the list of PRs https://github.com/cms-sw/cmssw/pulls

hjbossi commented 1 day ago

Sure, I have done this!

mandrenguyen commented 1 day ago

urgent

cmsbuild commented 1 day ago

Pull request #46544 was updated. @aloeliger, @atpathak, @cmsbuild, @consuegs, @epalencia, @perrotta can you please check and sign again.

mandrenguyen commented 1 day ago

please test workflow 142

cmsbuild commented 1 day ago

-1

Failed Tests: RelVals Size: This PR adds an extra 12KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f926ce/42481/summary.html COMMIT: a731a599059661cebdba9cac4dcb1a405d723ff5 CMSSW: CMSSW_14_1_X_2024-10-30-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46544/42481/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

29696.0

----- Begin Fatal Exception 30-Oct-2024 18:00:26 CET-----------------------
An exception of category 'ERROR: ZDC trigger spacing factor, taken from auxi2 field of HCALTPChannelParameters, is set to the default value of 0, which is an incompatible value for a spacing factor. Cannot continue safely.' occurred while
[0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
[1] Running path 'HLTriggerFinalPath'
[2] Prefetching for module TriggerSummaryProducerAOD/'hltTriggerSummaryAOD'
[3] Prefetching for module L1CaloJetProducer/'l1tCaloJet'
[4] Prefetching for module L1TowerCalibrator/'l1tTowerCalibration'
[5] Prefetching for module L1EGCrystalClusterEmulatorProducer/'l1tEGammaClusterEmuProducer'
[6] Prefetching for module HcalTrigPrimDigiProducer/'simHcalTriggerPrimitiveDigis'
[7] Calling method for EventSetup module HcalTPGCoderULUT/''
----- End Fatal Exception -------------------------------------------------

29700.0

----- Begin Fatal Exception 30-Oct-2024 18:00:37 CET-----------------------
An exception of category 'ERROR: ZDC trigger spacing factor, taken from auxi2 field of HCALTPChannelParameters, is set to the default value of 0, which is an incompatible value for a spacing factor. Cannot continue safely.' occurred while
[0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
[1] Running path 'HLTriggerFinalPath'
[2] Prefetching for module TriggerSummaryProducerAOD/'hltTriggerSummaryAOD'
[3] Prefetching for module L1CaloJetProducer/'l1tCaloJet'
[4] Prefetching for module L1TowerCalibrator/'l1tTowerCalibration'
[5] Prefetching for module L1EGCrystalClusterEmulatorProducer/'l1tEGammaClusterEmuProducer'
[6] Prefetching for module HcalTrigPrimDigiProducer/'simHcalTriggerPrimitiveDigis'
[7] Calling method for EventSetup module HcalTPGCoderULUT/''
----- End Fatal Exception -------------------------------------------------

29634.0

----- Begin Fatal Exception 30-Oct-2024 18:02:31 CET-----------------------
An exception of category 'ERROR: ZDC trigger spacing factor, taken from auxi2 field of HCALTPChannelParameters, is set to the default value of 0, which is an incompatible value for a spacing factor. Cannot continue safely.' occurred while
[0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
[1] Running path 'HLTriggerFinalPath'
[2] Prefetching for module TriggerSummaryProducerAOD/'hltTriggerSummaryAOD'
[3] Prefetching for module L1CaloJetProducer/'l1tCaloJet'
[4] Prefetching for module L1TowerCalibrator/'l1tTowerCalibration'
[5] Prefetching for module L1EGCrystalClusterEmulatorProducer/'l1tEGammaClusterEmuProducer'
[6] Prefetching for module HcalTrigPrimDigiProducer/'simHcalTriggerPrimitiveDigis'
[7] Calling method for EventSetup module HcalTPGCoderULUT/''
----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

29834.999
24834.911
29634.911

cmsbuild commented 1 day ago

Pull request #46544 was updated. @aloeliger, @atpathak, @cmsbuild, @consuegs, @epalencia, @perrotta can you please check and sign again.

mandrenguyen commented 1 day ago

please test workflow 142

cmsbuild commented 1 day ago

+1

Size: This PR adds an extra 20KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f926ce/42492/summary.html COMMIT: 0e10641380b8fb867e396a57a5d50bc6a591cf64 CMSSW: CMSSW_14_1_X_2024-10-30-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46544/42492/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 11 lines to the logs
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 47
DQMHistoTests: Total histograms compared: 3628433
DQMHistoTests: Total failures: 3
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3628410
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 46 files compared)
Checked 203 log files, 172 edm output root files, 47 DQM output files
TriggerResults: no differences found

perrotta commented 7 hours ago

@hjbossi please update as in the master

cmsbuild commented 6 hours ago

Pull request #46544 was updated. @aloeliger, @atpathak, @cmsbuild, @consuegs, @epalencia, @perrotta can you please check and sign again.

hjbossi commented 5 hours ago

@hjbossi please update as in the master

Thanks! I somehow missed this! It is now updated!

perrotta commented 5 hours ago

please test workflow 142

cmsbuild commented 1 hour ago

+1

Size: This PR adds an extra 16KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f926ce/42524/summary.html COMMIT: 38697aeb6a1e3eee750faa0653618ecdd12626f9 CMSSW: CMSSW_14_1_X_2024-10-31-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46544/42524/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 115 lines to the logs
Reco comparison results: 9 differences found in the comparisons
DQMHistoTests: Total files compared: 47
DQMHistoTests: Total histograms compared: 3628433
DQMHistoTests: Total failures: 5
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3628408
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 46 files compared)
Checked 203 log files, 172 edm output root files, 47 DQM output files
TriggerResults: no differences found

cms-sw / cmssw