cms-sw / cmssw

CMS Offline Software
http://cms-sw.github.io/
Apache License 2.0
1.08k stars 4.31k forks source link

Downgrade EnergyInDeadEB/EE_FE Warning To Info #46545

Open ReyerBand opened 1 day ago

ReyerBand commented 1 day ago

PR description:

This PR addresses unnecessary warnings raised in hltEcalRecHit, noted in #41456 and #45880. These warnings are really just reporting energy calculated from the TP and don't indicate a problem, so they are to be downgraded from LogWarning to LogInfo.

cmsbuild commented 1 day ago

cms-bot internal usage

cmsbuild commented 1 day ago

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46545/42419

cmsbuild commented 1 day ago

A new Pull Request was created by @ReyerBand for master.

It involves the following packages:

@cmsbuild, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks. @ReyerBand, @apsallid, @argiro, @missirol, @rchatter, @thomreis, @wang0jin, @youyingli this is something you requested to watch as well. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

mmusich commented 1 day ago

@cmsbuild, please test

cmsbuild commented 1 day ago

-1

Failed Tests: RelVals-INPUT Size: This PR adds an extra 20KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-42f428/42458/summary.html COMMIT: d6d3fbd58895ac895b03476ce53f77e2a1de4292 CMSSW: CMSSW_14_2_X_2024-10-29-2300/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46545/42458/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

Comparison Summary

Summary:

jfernan2 commented 1 day ago

fixes https://github.com/cms-sw/cmssw/issues/45880