search

cms-sw / cmssw

CMS Offline Software
http://cms-sw.github.io/
Apache License 2.0
1.08k stars 4.31k forks source link

Run3-hgx378XX Provide the missing file to avoid the failure in Unit Test for merging of #46468 #46546

Closed bsunanda closed 1 day ago

bsunanda commented 1 day ago

PR description:

Provide the missing file to avoid the failure in the Unit Test due to merging of the PR #46468

PR validation:

Avoid the unit test failure

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Avoid unit test failure

bsunanda commented 1 day ago

urgent

cmsbuild commented 1 day ago

A new Pull Request was created by @bsunanda for CMSSW_14_1_X.

It involves the following packages:

@Dr15Jones, @bsunanda, @civanch, @cmsbuild, @kpedro88, @makortel, @mdhildreth can you please review it and eventually sign? Thanks. @fabiocos, @martinamalberti this is something you requested to watch as well. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

cmsbuild commented 1 day ago

cms-bot internal usage

bsunanda commented 1 day ago

type BugFix

bsunanda commented 1 day ago

@cmsbuild Please test

bsunanda commented 1 day ago

+geometry

cmsbuild commented 1 day ago

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_1_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_14_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

mmusich commented 1 day ago

hold

mmusich commented 1 day ago

@cmsbuild, please abort

cmsbuild commented 1 day ago

Pull request has been put on hold by @mmusich They need to issue an unhold command to remove the hold state or L1 can unhold it for all

mmusich commented 1 day ago

test parameters:

mmusich commented 1 day ago

@cmsbuild, please test

mmusich commented 1 day ago

@bsunanda why are you backporting a single file? In https://github.com/cms-sw/cmssw/pull/46351 you did add more scenarios.

bsunanda commented 1 day ago

This file was the missing one in the unit tests.

From: Marco Musich @.> Sent: 30 October 2024 13:42 To: cms-sw/cmssw @.> Cc: Sunanda Banerjee @.>; Mention @.> Subject: Re: [cms-sw/cmssw] Run3-hgx378XX Provide the missing file to avoid the failure in Unit Test for merging of #46468 (PR #46546)

@bsunandahttps://github.com/bsunanda why are you backporting a single file? In #46351https://github.com/cms-sw/cmssw/pull/46351 you did add more scenarios.

— Reply to this email directly, view it on GitHubhttps://github.com/cms-sw/cmssw/pull/46546#issuecomment-2446125253, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABGMZOQMSUW3OIN2BNOXQETZ6CIF5AVCNFSM6AAAAABQ3NRLKSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINBWGEZDKMRVGM. You are receiving this because you were mentioned.Message ID: @.***>

mmusich commented 1 day ago

unhold

cmsbuild commented 1 day ago

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_1_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_14_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @mandrenguyen, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild commented 1 day ago

+1

Size: This PR adds an extra 16KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8d9922/42464/summary.html COMMIT: c5cb12094f7966dfb4b92184fb7ca368306d0237 CMSSW: CMSSW_14_1_X_2024-10-29-2300/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46546/42464/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

mandrenguyen commented 1 day ago

@bsunanda It passes tests, but it seems better to take the complete backport: https://github.com/cms-sw/cmssw/pull/46547

Do you want to pre-sign that one as well and i'll merge it instead of this one?

bsunanda commented 1 day ago

It is up to you to decide. The other files are meant for changes in Geometry/CMSCommonData for changes in 2016, 2017, 2018 geometries and appropriate changes in HcalTopology. If you do not backport them, backporting only hcalRecNumbering will not help. Please suggest what should be done

From: Matthew Nguyen @.> Sent: 30 October 2024 16:54 To: cms-sw/cmssw @.> Cc: Sunanda Banerjee @.>; Mention @.> Subject: Re: [cms-sw/cmssw] Run3-hgx378XX Provide the missing file to avoid the failure in Unit Test for merging of #46468 (PR #46546)

@bsunandahttps://github.com/bsunanda It passes tests, but it seems better to take the complete backport: #46547https://github.com/cms-sw/cmssw/pull/46547

Do you want to pre-sign that one as well and i'll merge it instead of this one?

— Reply to this email directly, view it on GitHubhttps://github.com/cms-sw/cmssw/pull/46546#issuecomment-2446701841, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABGMZOUMLN7WHY5KOOTIXITZ6C6X3AVCNFSM6AAAAABQ3NRLKSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINBWG4YDCOBUGE. You are receiving this because you were mentioned.Message ID: @.***>

mandrenguyen commented 1 day ago

It is up to you to decide. The other files are meant for changes in Geometry/CMSCommonData for changes in 2016, 2017, 2018 geometries and appropriate changes in HcalTopology. If you do not backport them, backporting only hcalRecNumbering will not help. Please suggest what should be done

I must admit I cannot really parse this. Do you confirm that it's ok to merge that PR instead of this one?

bsunanda commented 1 day ago

This is the minimum addition that can cure the unit test failure. The other PR also cures the unit test failure but some of the extra files which are added are not strictly necessary. They were required for 14_2_X for updating several Run2 scenarios and the corresponding changes in the HcalTopology code. Since those changes will not be backported to 14_1_X, I am not sure if backporting the entire 46531 is necessary. Both the PRs will be fixing the unit test. If you integrate #46544 I shall close this. Otherwise please integrate this one and ask Marco to close #46544

From: Matthew Nguyen @.> Sent: 30 October 2024 17:19 To: cms-sw/cmssw @.> Cc: Sunanda Banerjee @.>; Mention @.> Subject: Re: [cms-sw/cmssw] Run3-hgx378XX Provide the missing file to avoid the failure in Unit Test for merging of #46468 (PR #46546)

It is up to you to decide. The other files are meant for changes in Geometry/CMSCommonData for changes in 2016, 2017, 2018 geometries and appropriate changes in HcalTopology. If you do not backport them, backporting only hcalRecNumbering will not help. Please suggest what should be done

I must admit I cannot really parse this. Do you confirm that it's ok to merge that PR instead of this one?

— Reply to this email directly, view it on GitHubhttps://github.com/cms-sw/cmssw/pull/46546#issuecomment-2446816522, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABGMZOQ3EQUN22GVDDT4Q3LZ6DBWLAVCNFSM6AAAAABQ3NRLKSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINBWHAYTMNJSGI. You are receiving this because you were mentioned.Message ID: @.***>

mandrenguyen commented 1 day ago

@bsunanda #46544 is something else entirely, no?

mandrenguyen commented 1 day ago

+1 After discussing with @mmusich we merge this one for simplicity