search

cms-sw / cmssw

CMS Offline Software
http://cms-sw.github.io/
Apache License 2.0
1.08k stars 4.31k forks source link

static-analyzer: treat relative file names as local CMS files #46554

Closed smuzaffar closed 11 hours ago

smuzaffar commented 1 day ago

Static analyzer was relaying on the fact that all files compiled have full path(e.g $CMSSW_BASE/src/package/file.ext) but scram now uses relative path (e.g. src/package/file.ext ) for portable PGO profiles. This PR fixes this issue and treat all files name started with src/ as local CMS files.

smuzaffar commented 1 day ago

please test

cmsbuild commented 1 day ago

cms-bot internal usage

cmsbuild commented 1 day ago

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46554/42435

cmsbuild commented 1 day ago

A new Pull Request was created by @smuzaffar for master.

It involves the following packages:

@Dr15Jones, @makortel, @smuzaffar can you please review it and eventually sign? Thanks. @wddgit this is something you requested to watch as well. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

cmsbuild commented 1 day ago

-1

Failed Tests: RelVals-INPUT Size: This PR adds an extra 20KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1c42a2/42476/summary.html COMMIT: 968f22f0b965e23bcb0602915543907d8e8d360b CMSSW: CMSSW_14_2_X_2024-10-30-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46554/42476/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

Comparison Summary

Summary:

smuzaffar commented 1 day ago

please test

cmsbuild commented 23 hours ago

-1

Failed Tests: RelVals-INPUT Size: This PR adds an extra 20KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1c42a2/42493/summary.html COMMIT: 968f22f0b965e23bcb0602915543907d8e8d360b CMSSW: CMSSW_14_2_X_2024-10-30-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46554/42493/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

Comparison Summary

Summary:

smuzaffar commented 17 hours ago

@makortel , @gartung any objection on this change?

makortel commented 17 hours ago

Looks good to me. I'd wait @gartung to comment too.

gartung commented 11 hours ago

Looks good to me,

smuzaffar commented 11 hours ago

ignore tests-rejected with ib-failure

smuzaffar commented 11 hours ago

+core

cmsbuild commented 11 hours ago

This pull request is fully signed and it will be integrated in one of the next master IBs (test failures were overridden). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

mandrenguyen commented 11 hours ago

+1