cms-sw / cmssw

CMS Offline Software
http://cms-sw.github.io/
Apache License 2.0
1.08k stars 4.31k forks source link

PrintTkMaps: Prefer to use data files from local area #46561

Open smuzaffar opened 1 day ago

smuzaffar commented 1 day ago

https://github.com/cms-sw/cmssw/pull/46456 added a unit tests which was picking up data files from cmssw release area only. This unit test will fail for full build IBs or PRs where we build full cmssw ( e.g https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5860f1/42470/unitTests/src/DQM/TrackerRemapper/test/testPrintTkMaps/testing.log ).

This PR fixes this issue by first looking for data files in local cmssw area and fallback to release if data file is missing in local area.

FYI @mmusich

smuzaffar commented 1 day ago

please test

cmsbuild commented 1 day ago

cms-bot internal usage

cmsbuild commented 1 day ago

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46561/42441

cmsbuild commented 1 day ago

A new Pull Request was created by @smuzaffar for master.

It involves the following packages:

@antoniovagnerini, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks. @fioriNTU, @idebruyn, @jandrea, @mmusich, @threus this is something you requested to watch as well. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

cmsbuild commented 1 day ago

-1

Failed Tests: RelVals-INPUT Size: This PR adds an extra 16KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-508c44/42488/summary.html COMMIT: 4534239d8f5349294f81c312b502edb7d5c4a46c CMSSW: CMSSW_14_2_X_2024-10-30-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46561/42488/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

Comparison Summary

Summary:

smuzaffar commented 13 hours ago

@cms-sw/dqm-l2 , can you please review this. This change makes sure that unit tests picks up local data files

smuzaffar commented 13 hours ago

ignore tests-rejected with ib-failure