search

cms-sw / cmssw

CMS Offline Software
http://cms-sw.github.io/
Apache License 2.0
1.08k stars 4.31k forks source link

add `ClusterShapeHitFilterESProducer_cfi` to `dedxEstimators_Cosmics_cff` as it's now requested by `DeDxHitInfoProducer` #46563

Closed mmusich closed 6 hours ago

mmusich commented 17 hours ago

PR description:

Simple fix for https://github.com/cms-sw/cmssw/issues/46553 resolves https://github.com/cms-sw/cmssw/issues/46553

PR validation:

cmsRun DQM/Integration/python/clients/visualization-live-secondInstance_cfg.py runInputDir=/eos/user/d/dpapagia/data outputBaseDir=./output runNumber=387552 runkey=cosmic_run

runs fine (streamers courtesy of @nothingface0)

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, but will need to be backported to CMSSW_14_1_X for operations during 2024 HIon run.

mmusich commented 17 hours ago

type bug-fix

mmusich commented 17 hours ago

urgent

cmsbuild commented 17 hours ago

cms-bot internal usage

cmsbuild commented 17 hours ago

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46563/42446

cmsbuild commented 17 hours ago

A new Pull Request was created by @mmusich for master.

It involves the following packages:

@cmsbuild, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks. @GiacomoSguazzoni, @VinInn, @VourMa, @dgulhan, @felicepantaleo, @gpetruc, @missirol, @mmusich, @mtosi, @rovere this is something you requested to watch as well. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

mmusich commented 17 hours ago

@cmsbuild, please test

mandrenguyen commented 12 hours ago

ignore tests-rejected with ib-failure

jfernan2 commented 9 hours ago

+1

cmsbuild commented 9 hours ago

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild commented 9 hours ago

-1

Failed Tests: RelVals-INPUT Size: This PR adds an extra 16KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b58df8/42497/summary.html COMMIT: 573391801a9bf9b650c495679b7bad71481c5c46 CMSSW: CMSSW_14_2_X_2024-10-30-2300/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46563/42497/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

Comparison Summary

Summary:

mandrenguyen commented 6 hours ago

ignore tests-rejected with ib-failure

mandrenguyen commented 6 hours ago

+1